Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2255663002: [Remoting Android] Use floating point coords for rendering the cursor (Closed)

Created:
4 years, 4 months ago by Yuwei
Modified:
4 years, 4 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Use floating point coords for rendering the cursor Currently we use integer coords when calculating cursor position and rendering the cursor so the pixels we are locking the cursor to are very apparent when the zoom level is increased. This CL makes the client use floating point coords for rendering the cursor so that the position finer-grained than a pixel. BUG=638307 Committed: https://crrev.com/b70334d145c8c58ccd2529fd7416bc27a685ddea Cr-Commit-Position: refs/heads/master@{#412909}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Reviewer's Feedback #

Patch Set 3 : Merge ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -58 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/AbstractDesktopView.java View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/InputEventSender.java View 1 2 chunks +9 lines, -9 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/RenderData.java View 1 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TrackpadInputStrategy.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/client/gl_cursor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/client/gl_cursor.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/gl_cursor_feedback.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/gl_cursor_feedback.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/gl_renderer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/gl_renderer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/jni/jni_gl_display_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/client/jni/jni_gl_display_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Yuwei
ptal
4 years, 4 months ago (2016-08-17 01:37:34 UTC) #2
joedow
https://codereview.chromium.org/2255663002/diff/1/remoting/android/java/src/org/chromium/chromoting/DesktopView.java File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right): https://codereview.chromium.org/2255663002/diff/1/remoting/android/java/src/org/chromium/chromoting/DesktopView.java#newcode1 remoting/android/java/src/org/chromium/chromoting/DesktopView.java:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
4 years, 4 months ago (2016-08-17 17:08:15 UTC) #3
Yuwei
ptal https://codereview.chromium.org/2255663002/diff/1/remoting/android/java/src/org/chromium/chromoting/DesktopView.java File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right): https://codereview.chromium.org/2255663002/diff/1/remoting/android/java/src/org/chromium/chromoting/DesktopView.java#newcode1 remoting/android/java/src/org/chromium/chromoting/DesktopView.java:1: // Copyright 2013 The Chromium Authors. All rights ...
4 years, 4 months ago (2016-08-17 17:42:46 UTC) #4
Yuwei
ping!
4 years, 4 months ago (2016-08-18 18:33:00 UTC) #5
joedow
lgtm
4 years, 4 months ago (2016-08-18 18:38:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255663002/40001
4 years, 4 months ago (2016-08-18 18:40:52 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-18 19:23:35 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 19:26:00 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b70334d145c8c58ccd2529fd7416bc27a685ddea
Cr-Commit-Position: refs/heads/master@{#412909}

Powered by Google App Engine
This is Rietveld 408576698