Floating builder logic waits at startup.

Floating builder logic waits at startup.

Currently, the floating builder logic considered slaves that haven't
ever signed in as last seen a long time ago (epoch). This means that if
a master starts up, has a task, and a floating builder connects before a
primary, the floating builder will be immediately given the task, since
the primary is outside of the grace period.

Update this logic: now all slaves are considered last seen when the
floating function was created. This will cause the floating builder to
wait a full grace period before giving builds to floating slaves, even
if it just started up.

BUG=chromium:637166
TEST=None

Committed: https://chromium.googlesource.com/chromium/tools/build/+/d521c25d75f302880ffaa2e5f10aa5cfe1c932cb

[dnj, 2016-08-17 01:03:55]

dnj@chromium.org changed reviewers:
+ bpastene@chromium.org

[dnj, 2016-08-17 01:03:56]

PTAL

[bpastene, 2016-08-17 01:22:13]

lgtm + a question

https://codereview.chromium.org/2255643002/diff/1/scripts/master/floating_bui...
File scripts/master/floating_builder.py (right):

https://codereview.chromium.org/2255643002/diff/1/scripts/master/floating_bui...
scripts/master/floating_builder.py:192: #
nit: remove line

https://codereview.chromium.org/2255643002/diff/1/scripts/master/floating_bui...
scripts/master/floating_builder.py:270: if not times:
OOC, would times ever be empty here? If I'm reading this right, all primary and
floating slaves get a last_seen_time when the func is initialized

[dnj, 2016-08-17 01:24:17]

https://codereview.chromium.org/2255643002/diff/1/scripts/master/floating_bui...
File scripts/master/floating_builder.py (right):

https://codereview.chromium.org/2255643002/diff/1/scripts/master/floating_bui...
scripts/master/floating_builder.py:192: #
On 2016/08/17 01:22:13, bpastene wrote:
> nit: remove line

Done.

https://codereview.chromium.org/2255643002/diff/1/scripts/master/floating_bui...
scripts/master/floating_builder.py:270: if not times:
On 2016/08/17 01:22:13, bpastene wrote:
> OOC, would times ever be empty here? If I'm reading this right, all primary
and
> floating slaves get a last_seen_time when the func is initialized

Oh yeah that's not needed anymore.

[dnj, 2016-08-17 01:24:54]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-08-17 01:24:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
bpastene@chromium.org
Link to the patchset: https://codereview.chromium.org/2255643002/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2016-08-17 01:25:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 01:31:44]

Description was changed from

==========
Floating builder logic waits at startup.

Currently, the floating builder logic considered slaves that haven't
ever signed in as last seen a long time ago (epoch). This means that if
a master starts up, has a task, and a floating builder connects before a
primary, the floating builder will be immediately given the task, since
the primary is outside of the grace period.

Update this logic: now all slaves are considered last seen when the
floating function was created. This will cause the floating builder to
wait a full grace period before giving builds to floating slaves, even
if it just started up.

BUG=chromium:637166
TEST=None
==========

to

==========
Floating builder logic waits at startup.

Currently, the floating builder logic considered slaves that haven't
ever signed in as last seen a long time ago (epoch). This means that if
a master starts up, has a task, and a floating builder connects before a
primary, the floating builder will be immediately given the task, since
the primary is outside of the grace period.

Update this logic: now all slaves are considered last seen when the
floating function was created. This will cause the floating builder to
wait a full grace period before giving builds to floating slaves, even
if it just started up.

BUG=chromium:637166
TEST=None

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d521c25d75f302880ffa...
==========

[commit-bot: I haz the power, 2016-08-17 01:31:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/d521c25d75f302880ffa...