Floating builder logic waits at startup.

scripts/master/unittests/floating_builder_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Source file for floating builder testcases."""
 
 import calendar
 import datetime
 import itertools
@@ skipping 105 matching lines @@
   def setUp(self):
     self._mocks = (
       mock.patch('master.floating_builder._get_now'),
       mock.patch('master.floating_builder.PokeBuilderTimer.reset'),
     )
     for patcher in self._mocks:
       patcher.start()
 
     # Mock current date/time.
     self.now = datetime.datetime(2016, 1, 1, 8, 0, 0) # 1/1/2016 @8:00
-    fb._get_now.return_value = self.now
+    fb._get_now.side_effect = lambda: self.now
 
     # Mock PokeBuilderTimer to record when the poke builder was set, but not
     # actually schedule any reactor magic.
     self.poke_delta = None
     def record_poke_delta(delta):
       self.poke_delta = delta
     fb.PokeBuilderTimer.reset.side_effect = record_poke_delta
 
     self._slaves = dict((s, _FakeSlave(s)) for s in (
         'primary-a', 'primary-b', 'floating-a', 'floating-b',
     ))
 
     self.builder = _FakeBuilder(
         'Test Builder',
         [s[1] for s in sorted(self._slaves.iteritems())],
     )
 
   def tearDown(self):
     for patcher in reversed(self._mocks):
       patcher.stop()
 
+  def testJustStartedNoPrimariesOnlineWaits(self):
+    fs = fb.FloatingSet()
+    fs.AddPrimary('primary-a')
+    fs.AddFloating('floating-a', 'floating-b')
+    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
+
+    self.builder.set_online_slaves('floating-a', 'floating-b')
+
+    nsb = fnsf(self.builder, self.builder.slavebuilders)
+    self.assertIsNone(nsb)
+    self.assertEqual(self.poke_delta, datetime.timedelta(seconds=10))
+
+    self.now += datetime.timedelta(seconds=11)
+    nsb = fnsf(self.builder, self.builder.slavebuilders)
+    self.assertIsNotNone(nsb)
+    self.assertEqual(nsb.slave.slavename, 'floating-a')
+
   def testPrimaryBuilderIsSelectedWhenAvailable(self):
     fs = fb.FloatingSet()
     fs.AddPrimary('primary-a')
     fs.AddFloating('floating-a', 'floating-b')
+    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
 
     self.builder.set_online_slaves('primary-a', 'floating-a', 'floating-b')
 
-    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
     nsb = fnsf(self.builder, self.builder.slavebuilders)
     self.assertIsNotNone(nsb)
     self.assertEqual(nsb.slave.slavename, 'primary-a')
 
   def testPrimaryBuilderIsSelectedWhenOneIsAvailableAndOneIsBusy(self):
     fs = fb.FloatingSet()
     fs.AddPrimary('primary-a', 'primary-b')
     fs.AddFloating('floating-a', 'floating-b')
+    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
 
     self.builder.set_online_slaves('primary-a', 'primary-b', 'floating-a',
                                    'floating-b')
     self.builder.set_busy_slaves('primary-a')
 
-    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
     nsb = fnsf(self.builder, self.builder.slavebuilders)
     self.assertIsNotNone(nsb)
     self.assertEqual(nsb.slave.slavename, 'primary-b')
 
   def testNoBuilderIsSelectedWhenPrimariesAreOfflineWithinGrace(self):
     fs = fb.FloatingSet()
     fs.AddPrimary('primary-a', 'primary-b')
     fs.AddFloating('floating-a', 'floating-b')
+    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
 
+    self.now += datetime.timedelta(seconds=30)
     self.builder.set_online_slaves('floating-a')
     self._slaves['primary-b']._set_last_seen(self.now, seconds=-1)
 
-    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
     nsb = fnsf(self.builder, self.builder.slavebuilders)
     self.assertIsNone(nsb)
     self.assertEqual(self.poke_delta, datetime.timedelta(seconds=9))
 
   def testFloatingBuilderIsSelectedWhenPrimariesAreOfflineForAWhile(self):
     fs = fb.FloatingSet()
     fs.AddPrimary('primary-a', 'primary-b')
     fs.AddFloating('floating-a', 'floating-b')
+    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
 
+    self.now += datetime.timedelta(seconds=30)
     self.builder.set_online_slaves('floating-a')
 
-    fnsf = fs.NextSlaveFunc(datetime.timedelta(seconds=10))
     nsb = fnsf(self.builder, self.builder.slavebuilders)
     self.assertIsNotNone(nsb)
     self.assertEqual(nsb.slave.slavename, 'floating-a')
 
 
 if __name__ == '__main__':
   unittest.main()