Adding a DataSaverStatus interface to DataReductionProxy

Adding a DataSaverStatus interface to DataReductionProxy

This interface is implemented by DataReductionProxySettings.

It introduces a simple method, IsDataSaverEnabled, that can be consumed
by previews/ without taking a dependency on
data_reduction_proxy/core/browser and maintaining a strict interface
between data_reduction_proxy/ and previews/.

BUG=615565
Committed: https://crrev.com/a9416333053323014955b288096e9f80eb5a3863
Cr-Commit-Position: refs/heads/master@{#413308}

[RyanSturm, 2016-08-16 22:56:02]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 22:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 23:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:54:35]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-08-17 22:11:28]

ryansturm@chromium.org changed reviewers:
+ bengr@chromium.org

[RyanSturm, 2016-08-17 22:11:29]

bengr: PTAL @ *

[bengr, 2016-08-18 16:52:58]

https://codereview.chromium.org/2255603002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
(right):

https://codereview.chromium.org/2255603002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:368:
bool DataReductionProxySettings::IsDataSaverEnabled() const {
It would be good to write a quick test for this to prevent regressions.

[RyanSturm, 2016-08-18 17:31:52]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 17:32:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-08-18 17:32:25]

bengr: PTAL

https://codereview.chromium.org/2255603002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
(right):

https://codereview.chromium.org/2255603002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:368:
bool DataReductionProxySettings::IsDataSaverEnabled() const {
On 2016/08/18 16:52:58, bengr wrote:
> It would be good to write a quick test for this to prevent regressions.

I added to TestIsProxyEnabledOrManaged to make sure it is consitent with 
IsDataReductionProxyEnabled.

[commit-bot: I haz the power, 2016-08-18 20:12:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:12:23]

Dry run: This issue passed the CQ dry run.

[bengr, 2016-08-19 20:44:04]

lgtm

[RyanSturm, 2016-08-19 20:47:30]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 20:48:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 22:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 22:13:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[RyanSturm, 2016-08-19 22:15:27]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-08-19 22:15:27]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/2255603002/#ps40001
(title: "Adding depending CL")

[commit-bot: I haz the power, 2016-08-19 22:16:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 00:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:05:35]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[RyanSturm, 2016-08-20 00:10:32]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:11:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 02:15:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-20 02:17:09]

Description was changed from

==========
Adding a DataSaverStatus interface to DataReductionProxy

This interface is implemented by DataReductionProxySettings.

It introduces a simple method, IsDataSaverEnabled, that can be consumed
by previews/ without taking a dependency on
data_reduction_proxy/core/browser and maintaining a strict interface
between data_reduction_proxy/ and previews/.

BUG=615565
==========

to

==========
Adding a DataSaverStatus interface to DataReductionProxy

This interface is implemented by DataReductionProxySettings.

It introduces a simple method, IsDataSaverEnabled, that can be consumed
by previews/ without taking a dependency on
data_reduction_proxy/core/browser and maintaining a strict interface
between data_reduction_proxy/ and previews/.

BUG=615565

Committed: https://crrev.com/a9416333053323014955b288096e9f80eb5a3863
Cr-Commit-Position: refs/heads/master@{#413308}
==========

[commit-bot: I haz the power, 2016-08-20 02:17:10]

Patchset 3 (id:??) landed as
https://crrev.com/a9416333053323014955b288096e9f80eb5a3863
Cr-Commit-Position: refs/heads/master@{#413308}