Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2249903004: Adding a DataSavingsRecorder interface (Closed)

Created:
4 years, 4 months ago by RyanSturm
Modified:
4 years, 4 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a DataSavingsRecorder interface This interface is implemented by DataReductionProxyCompressionStats and provides a way for interventions that save data to report data savings after the fact. All URLRequests data are recorded, and when data saver is enabled, data savings is also recorded. BUG=615565 Committed: https://crrev.com/d6cf9b0695ef2f04cb7c3878caf45879d486d8de Cr-Commit-Position: refs/heads/master@{#413264}

Patch Set 1 #

Patch Set 2 : missed a file #

Patch Set 3 : Self review #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : bengr comments #

Messages

Total messages: 21 (16 generated)
RyanSturm
bengr: PTAL @ *
4 years, 4 months ago (2016-08-17 22:11:16 UTC) #10
bengr
Lgtm with a comment nit. https://codereview.chromium.org/2249903004/diff/60001/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc (right): https://codereview.chromium.org/2249903004/diff/60001/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc#newcode1018 components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:1018: // Don't record any ...
4 years, 4 months ago (2016-08-19 20:35:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249903004/80001
4 years, 4 months ago (2016-08-19 20:45:48 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-19 22:12:15 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 22:14:57 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d6cf9b0695ef2f04cb7c3878caf45879d486d8de
Cr-Commit-Position: refs/heads/master@{#413264}

Powered by Google App Engine
This is Rietveld 408576698