Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2255563002: Add constructor for DOMMatrixReadOnly (Closed)

Created:
4 years, 4 months ago by xlai (Olivia)
Modified:
4 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add constructor for DOMMatrixReadOnly According to the spec (https://www.w3.org/TR/geometry-1/#dom-dommatrixreadonly), DOMMatrixReadOnly has a constructor that takes a number sequence and construct a 2D matrix when it has 6 elements or a 3D matrix when it has 16 elements. Otherwise it throws TypeError. BUG=388780 Committed: https://crrev.com/196420669e24edf2ba2d8d2811e690232bcac9ad Cr-Commit-Position: refs/heads/master@{#412902}

Patch Set 1 #

Patch Set 2 : Adding a layout test #

Total comments: 1

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
xlai (Olivia)
This CL tries to bring DOMMatrixReadOnly implementation up to date with the spec. My intention ...
4 years, 4 months ago (2016-08-16 19:51:27 UTC) #2
xlai (Olivia)
pdr@: Could you take a look at this?
4 years, 4 months ago (2016-08-17 18:30:14 UTC) #6
pdr.
On 2016/08/17 at 18:30:14, xlai wrote: > pdr@: Could you take a look at this? ...
4 years, 4 months ago (2016-08-17 22:18:51 UTC) #7
xlai (Olivia)
I've added a layout test.
4 years, 4 months ago (2016-08-18 14:48:31 UTC) #8
pdr.
LGTM with a nit. https://codereview.chromium.org/2255563002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html (right): https://codereview.chromium.org/2255563002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html#newcode1 third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html:1: <script src="../../resources/testharness.js"></script> Nit: please add ...
4 years, 4 months ago (2016-08-18 16:49:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255563002/60001
4 years, 4 months ago (2016-08-18 16:55:59 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-18 18:50:28 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 18:55:46 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/196420669e24edf2ba2d8d2811e690232bcac9ad
Cr-Commit-Position: refs/heads/master@{#412902}

Powered by Google App Engine
This is Rietveld 408576698