Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: blimp/client/core/contents/blimp_contents_impl.h

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass TabControlFeature* to BlimpContentsImpl's constructor, remove blimp contents factory Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_impl.h
diff --git a/blimp/client/core/contents/blimp_contents_impl.h b/blimp/client/core/contents/blimp_contents_impl.h
index 1110ccde6761bcdddd12dd9fc5bad20774843d16..1d1e1871accc7510c3be4e31f14e298819de67c8 100644
--- a/blimp/client/core/contents/blimp_contents_impl.h
+++ b/blimp/client/core/contents/blimp_contents_impl.h
@@ -25,11 +25,12 @@ class BlimpContentsImplAndroid;
class BlimpContentsObserver;
class BlimpNavigationController;
+class TabControlFeature;
class BlimpContentsImpl : public BlimpContents,
public BlimpNavigationControllerDelegate {
public:
- explicit BlimpContentsImpl(int id);
+ explicit BlimpContentsImpl(int id, TabControlFeature* tab_control_feature);
~BlimpContentsImpl() override;
#if defined(OS_ANDROID)
@@ -48,6 +49,13 @@ class BlimpContentsImpl : public BlimpContents,
// BlimpNavigationControllerDelegate implementation.
void OnNavigationStateChanged() override;
+ // Pushes the size and scale information to the engine, which will affect the
+ // web content display area for all tabs.
+ void SetSizeAndScale(const gfx::Size& size, float device_pixel_ratio);
+
+ // This method is added for testing purpose.
+ TabControlFeature* tab_control_feature() { return tab_control_feature_; }
David Trainor- moved to gerrit 2016/08/18 17:41:58 Do we need to expose this here? Could we just rel
Menglin 2016/08/19 00:50:21 Done.
+
int id() { return id_; }
private:
@@ -61,6 +69,10 @@ class BlimpContentsImpl : public BlimpContents,
// BlimpContentsManager to control the life time of the its observer.
int id_;
+ // The tab control feature through which the BlimpContentsImpl is able to
+ // set size and scale.
+ TabControlFeature* tab_control_feature_ = nullptr;
David Trainor- moved to gerrit 2016/08/18 17:41:58 Can we add a TODO and a bug to get rid of this and
Menglin 2016/08/19 00:50:21 Done.
+
DISALLOW_COPY_AND_ASSIGN(BlimpContentsImpl);
};

Powered by Google App Engine
This is Rietveld 408576698