blimp/client/core/contents/blimp_contents_manager.cc - Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_manager.cc

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass TabControlFeature* to BlimpContentsImpl's constructor, remove blimp contents factory Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/blimp_contents_manager.cc

diff --git a/blimp/client/core/contents/blimp_contents_manager.cc b/blimp/client/core/contents/blimp_contents_manager.cc

index f0a1f6bf560da4167512eb7a99ba49eced4195f3..26cac09f0ef16435fae396986055c27eee696edf 100644

--- a/blimp/client/core/contents/blimp_contents_manager.cc

+++ b/blimp/client/core/contents/blimp_contents_manager.cc

@@ -51,10 +51,11 @@ BlimpContentsManager::BlimpContentsManager() : weak_ptr_factory_(this) {}

BlimpContentsManager::~BlimpContentsManager() {}

-std::unique_ptr<BlimpContentsImpl> BlimpContentsManager::CreateBlimpContents() {

+std::unique_ptr<BlimpContentsImpl> BlimpContentsManager::CreateBlimpContents(

David Trainor- moved to gerrit 2016/08/18 17:41:58 This class should also call tab_control_feature->C

Menglin 2016/08/19 00:50:21 Done.

+ TabControlFeature* tab_control_feature) {

int id = CreateBlimpContentsId();

std::unique_ptr<BlimpContentsImpl> new_contents =

- base::MakeUnique<BlimpContentsImpl>(id);

+ base::MakeUnique<BlimpContentsImpl>(id, tab_control_feature);

std::unique_ptr<BlimpContentsDeletionObserver> observer =

base::MakeUnique<BlimpContentsDeletionObserver>(this, new_contents.get());

observer_map_.insert(