Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: blimp/client/core/contents/blimp_contents_impl.h

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_impl.h
diff --git a/blimp/client/core/contents/blimp_contents_impl.h b/blimp/client/core/contents/blimp_contents_impl.h
index 1110ccde6761bcdddd12dd9fc5bad20774843d16..e46fe842763795ac46b3d2961f2378dfe4766f03 100644
--- a/blimp/client/core/contents/blimp_contents_impl.h
+++ b/blimp/client/core/contents/blimp_contents_impl.h
@@ -25,6 +25,7 @@ class BlimpContentsImplAndroid;
class BlimpContentsObserver;
class BlimpNavigationController;
+class TabControlFeature;
class BlimpContentsImpl : public BlimpContents,
public BlimpNavigationControllerDelegate {
@@ -48,6 +49,15 @@ class BlimpContentsImpl : public BlimpContents,
// BlimpNavigationControllerDelegate implementation.
void OnNavigationStateChanged() override;
+ // Set the pointer to the tab control feature.
+ void SetTabControlFeature(TabControlFeature* tab_control_feature);
nyquist 2016/08/16 20:41:04 seems like this could just be set_tab_control_feat
Menglin 2016/08/16 21:10:09 if we pass in the tab control feature in BlimpCont
nyquist 2016/08/16 21:41:40 yeah
Menglin 2016/08/17 19:48:46 Done.
+
+ void SetSizeAndScale(const gfx::Size& size,
+ float device_pixel_ratio) override;
+
+ // This method is added for testing purpose.
+ TabControlFeature* tab_control_feature() { return tab_control_feature_; }
+
int id() { return id_; }
private:
@@ -61,6 +71,10 @@ class BlimpContentsImpl : public BlimpContents,
// BlimpContentsManager to control the life time of the its observer.
int id_;
+ // The tab control feature through which the BlimpContentsImpl is able to
+ // set size and scale.
+ TabControlFeature* tab_control_feature_ = nullptr;
+
DISALLOW_COPY_AND_ASSIGN(BlimpContentsImpl);
};

Powered by Google App Engine
This is Rietveld 408576698