Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3987)

Unified Diff: blimp/client/core/blimp_client_context_impl_unittest.cc

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/blimp_client_context_impl_unittest.cc
diff --git a/blimp/client/core/blimp_client_context_impl_unittest.cc b/blimp/client/core/blimp_client_context_impl_unittest.cc
index 55acec3a6e0fbd61559066e6974bb106c7a12ce8..9e41bb573abd40797e2365adb38d469e1663e66c 100644
--- a/blimp/client/core/blimp_client_context_impl_unittest.cc
+++ b/blimp/client/core/blimp_client_context_impl_unittest.cc
@@ -8,6 +8,8 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/threading/thread.h"
+#include "blimp/client/core/contents/blimp_contents_impl.h"
+#include "blimp/client/core/contents/tab_control_feature.h"
#include "blimp/client/public/blimp_client_context_delegate.h"
#include "blimp/client/public/contents/blimp_contents.h"
#include "blimp/client/test/test_blimp_client_context_delegate.h"
@@ -43,7 +45,8 @@ class BlimpClientContextImplTest : public testing::Test {
DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImplTest);
};
-TEST_F(BlimpClientContextImplTest, CreatedBlimpContentsGetsHelpersAttached) {
+TEST_F(BlimpClientContextImplTest,
+ CreatedBlimpContentsGetsHelpersAttachedAndHasTabControlFeature) {
BlimpClientContextImpl blimp_client_context(io_thread_.task_runner(),
io_thread_.task_runner());
TestBlimpClientContextDelegate delegate;
@@ -59,6 +62,13 @@ TEST_F(BlimpClientContextImplTest, CreatedBlimpContentsGetsHelpersAttached) {
blimp_client_context.CreateBlimpContents();
DCHECK(blimp_contents);
DCHECK_EQ(blimp_contents.get(), attached_blimp_contents);
+
+ BlimpContentsImpl* blimp_contents_impl = static_cast<BlimpContentsImpl*>(
+ blimp_contents.get());
+
+ DCHECK(blimp_contents_impl);
+ DCHECK_EQ(blimp_client_context.GetTabControlFeature(),
+ blimp_contents_impl->tab_control_feature());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698