Use testharness.js instead of js-test.js in fast/images.

Use testharness.js instead of js-test.js in fast/images.

1.Move code out of imagemap-dynamic-area-updates.js to html
and remove the js file.
2.Use testharness.js in img-dimensions-styled.html

BUG=637859
Committed: https://crrev.com/8aad247c738a74aef7bcb442bb990b31af90094d
Cr-Commit-Position: refs/heads/master@{#412304}

[sivag, 2016-08-16 14:10:17]

Description was changed from

==========
Use testharness.js instead of js-test.js in fast/images.

1.Move code out of imagemap-dynamic-area-updates.js to html
and remove the js file.
2.Use testharness.js in img-dimensions-styled.html

BUG=637859
==========

to

==========
Use testharness.js instead of js-test.js in fast/images.

1.Move code out of imagemap-dynamic-area-updates.js to html
and remove the js file.
2.Use testharness.js in img-dimensions-styled.html

BUG=637859
==========

[sivag, 2016-08-16 14:10:17]

siva.gunturi@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2016-08-16 14:22:20]

LGTM with comments addressed.

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html
(right):

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:19:
areaClicked = false;
make it local with "var" and move it above before its usage.

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:32:
console.log("eventSender");
you can remove these 3 lines.

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html
(right):

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html:2:
<title>Should used styled image dimensions if available.</title>
s/used/use

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html:14: var
image = document.getElementById("image");
remove id attribute and use document.querySelector("image");

[sivag, 2016-08-16 14:53:12]

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html
(right):

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:19:
areaClicked = false;
On 2016/08/16 14:22:19, Srirama wrote:
> make it local with "var" and move it above before its usage.
I think this is needed here
to get the access.

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:32:
console.log("eventSender");
On 2016/08/16 14:22:19, Srirama wrote:
> you can remove these 3 lines.

Done.

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html
(right):

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html:2:
<title>Should used styled image dimensions if available.</title>
On 2016/08/16 14:22:20, Srirama wrote:
> s/used/use

Done.

https://codereview.chromium.org/2255433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html:14: var
image = document.getElementById("image");
On 2016/08/16 14:22:20, Srirama wrote:
> remove id attribute and use document.querySelector("image");

Done.

[sivag, 2016-08-16 14:53:23]

siva.gunturi@samsung.com changed reviewers:
+ fs@opera.com

[sivag, 2016-08-16 14:53:36]

@fs, ptal..

[fs, 2016-08-16 15:17:07]

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html
(right):

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:24:
document.body.appendChild(map);
Could this just be added to the HTML directly?

<img usemap="#m" style="...">
  <map name="m">
    <area ...>
  </map>
</img>

or whatever it becomes.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:31:
function checkForArea(x, y) {
Nit: Maybe rename this to checkPointInArea or so. (Could probably merge setArea
and checkForArea too to save on the boilerplate.)

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:33:
eventSender.mouseMoveTo(x, y);
If elementFromPoint could be used here instead that might be more "upstreamable"
(but there's a similar test in WPT already though.) Feel free to add a TODO/Note
about that.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:39:
assert_equals(checkForArea(50, 50), true);
assert_equals(..., true) -> assert_true(...)

(Unless you want to make this test more data-driven.)

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:45:
assert_equals(checkForArea(150, 150), false);
assert_false

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:70:
document.body.removeChild(image);
No need for this I think.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html
(right):

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html:2:
<title>Should use styled image dimensions if available.</title>
Maybe make this "more to the point" now that we're updating it. I.e something
like "HTMLImageElement.width/height returns styled dimensions".

[sivag, 2016-08-16 16:43:00]

@fs, ptal..

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html
(right):

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:24:
document.body.appendChild(map);
On 2016/08/16 15:17:07, fs wrote:
> Could this just be added to the HTML directly?
> 
> <img usemap="#m" style="...">
>   <map name="m">
>     <area ...>
>   </map>
> </img>
> 
> or whatever it becomes.

Done.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:31:
function checkForArea(x, y) {
On 2016/08/16 15:17:07, fs wrote:
> Nit: Maybe rename this to checkPointInArea or so. (Could probably merge
setArea
> and checkForArea too to save on the boilerplate.)

Done.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:33:
eventSender.mouseMoveTo(x, y);
On 2016/08/16 15:17:07, fs wrote:
> If elementFromPoint could be used here instead that might be more
"upstreamable"
> (but there's a similar test in WPT already though.) Feel free to add a
TODO/Note
> about that.

Done.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:39:
assert_equals(checkForArea(50, 50), true);
On 2016/08/16 15:17:07, fs wrote:
> assert_equals(..., true) -> assert_true(...)
> 
> (Unless you want to make this test more data-driven.)

Done.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:45:
assert_equals(checkForArea(150, 150), false);
On 2016/08/16 15:17:07, fs wrote:
> assert_false

Done.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:70:
document.body.removeChild(image);
On 2016/08/16 15:17:07, fs wrote:
> No need for this I think.

Done.

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html
(right):

https://codereview.chromium.org/2255433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/img-dimensions-styled.html:2:
<title>Should use styled image dimensions if available.</title>
On 2016/08/16 15:17:07, fs wrote:
> Maybe make this "more to the point" now that we're updating it. I.e something
> like "HTMLImageElement.width/height returns styled dimensions".

Done.

[fs, 2016-08-16 16:56:19]

https://codereview.chromium.org/2255433002/diff/2/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html
(right):

https://codereview.chromium.org/2255433002/diff/2/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:5:
<img usemap="#m" width ="400" height="400" border="1px solid red"
position="absolute" left="0" right="0" >
'width', 'height' et.c should be in a style attribute:

style="width: 400px; height: 400px; border: ..."

https://codereview.chromium.org/2255433002/diff/2/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:12:
function CheckPointInArea(shape, cords, x, y) {
CheckPointInArea -> checkPointInArea; cords -> coords

[sivag, 2016-08-16 17:50:52]

@fs, ptal..

https://codereview.chromium.org/2255433002/diff/2/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html
(right):

https://codereview.chromium.org/2255433002/diff/2/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:5:
<img usemap="#m" width ="400" height="400" border="1px solid red"
position="absolute" left="0" right="0" >
On 2016/08/16 16:56:19, fs wrote:
> 'width', 'height' et.c should be in a style attribute:
> 
> style="width: 400px; height: 400px; border: ..."

Done.

https://codereview.chromium.org/2255433002/diff/2/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html:12:
function CheckPointInArea(shape, cords, x, y) {
On 2016/08/16 16:56:19, fs wrote:
> CheckPointInArea -> checkPointInArea; cords -> coords

Done.

[fs, 2016-08-16 18:05:04]

lgtm

[sivag, 2016-08-16 18:11:15]

The CQ bit was checked by siva.gunturi@samsung.com

[sivag, 2016-08-16 18:11:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
srirama.m@samsung.com
Link to the patchset: https://codereview.chromium.org/2255433002/#ps50001
(title: "Changed test as per the comments.")

[commit-bot: I haz the power, 2016-08-16 18:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 19:22:37]

Description was changed from

==========
Use testharness.js instead of js-test.js in fast/images.

1.Move code out of imagemap-dynamic-area-updates.js to html
and remove the js file.
2.Use testharness.js in img-dimensions-styled.html

BUG=637859
==========

to

==========
Use testharness.js instead of js-test.js in fast/images.

1.Move code out of imagemap-dynamic-area-updates.js to html
and remove the js file.
2.Use testharness.js in img-dimensions-styled.html

BUG=637859
==========

[commit-bot: I haz the power, 2016-08-16 19:22:38]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-08-16 19:25:15]

Description was changed from

==========
Use testharness.js instead of js-test.js in fast/images.

1.Move code out of imagemap-dynamic-area-updates.js to html
and remove the js file.
2.Use testharness.js in img-dimensions-styled.html

BUG=637859
==========

to

==========
Use testharness.js instead of js-test.js in fast/images.

1.Move code out of imagemap-dynamic-area-updates.js to html
and remove the js file.
2.Use testharness.js in img-dimensions-styled.html

BUG=637859

Committed: https://crrev.com/8aad247c738a74aef7bcb442bb990b31af90094d
Cr-Commit-Position: refs/heads/master@{#412304}
==========

[commit-bot: I haz the power, 2016-08-16 19:25:16]

Patchset 4 (id:??) landed as
https://crrev.com/8aad247c738a74aef7bcb442bb990b31af90094d
Cr-Commit-Position: refs/heads/master@{#412304}