third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html - Issue 2255433002: Use testharness.js instead of js-test.js in fast/images.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates.html

Issue 2255433002: Use testharness.js instead of js-test.js in fast/images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed test as per the review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE html>

2 <html>	2 <title>Test that when image map areas have their shape or coordinate dynamically altered, the clickable region changes.</title>

3 <head>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 </head>	5 <img usemap="#m" width ="400" height="400" border="1px solid red" position="abso lute" left="0" right="0" >
	fs 2016/08/16 16:56:19 'width', 'height' et.c should be in a style attrib 'width', 'height' et.c should be in a style attribute: style="width: 400px; height: 400px; border: ..." sivag 2016/08/16 17:50:52 Done. Show quoted text On 2016/08/16 16:56:19, fs wrote: > 'width', 'height' et.c should be in a style attribute: > > style="width: 400px; height: 400px; border: ..." Done.
6 <body>	6 <map name="m">

7 <script src="script-tests/imagemap-dynamic-area-updates.js"></script>	7 <area href="#" onclick="areaClicked = true; return false;">

8 </body>	8 </map>

9 </html>	9 <script>

	10 test(function() {

	11 var area = document.querySelector('area');

	12 function CheckPointInArea(shape, cords, x, y) {
	fs 2016/08/16 16:56:19 CheckPointInArea -> checkPointInArea; cords -> coo CheckPointInArea -> checkPointInArea; cords -> coords sivag 2016/08/16 17:50:52 Done. Show quoted text On 2016/08/16 16:56:19, fs wrote: > CheckPointInArea -> checkPointInArea; cords -> coords Done.
	13 area.setAttribute('shape', shape);

	14 area.setAttribute('coords', cords);

	15 areaClicked = false;

	16 // TODO(siva.gunturi): Use elementFromPoint here.

	17 eventSender.mouseMoveTo(x, y);

	18 eventSender.mouseDown();

	19 eventSender.mouseUp();

	20 return areaClicked;

	21 }

	22 assert_true(CheckPointInArea('default', '', 50, 50));

	23 assert_true(CheckPointInArea('default', '', 50, 50));

	24 assert_true(CheckPointInArea('rect', '0, 0, 100, 100', 50, 50));

	25 assert_false(CheckPointInArea('rect', '0, 0, 100, 100', 150, 150));

	26 assert_false(CheckPointInArea('rect', '200, 200, 300, 300', 50, 50));

	27 assert_true(CheckPointInArea('rect', '200, 200, 300, 300', 250, 250));

	28 assert_true(CheckPointInArea('circle', '100, 100, 50', 100, 100));

	29 assert_true(CheckPointInArea('circle', '100, 100, 50', 120, 100));

	30 assert_false(CheckPointInArea('circle', '100, 100, 50', 200, 100));

	31 assert_false(CheckPointInArea('circle', '300, 300, 50', 100, 100));

	32 assert_true(CheckPointInArea('circle', '300, 300, 50', 300, 300));

	33 assert_true(CheckPointInArea('circle', '300, 300, 50', 320, 300));

	34 assert_true(CheckPointInArea('poly', '100, 100, 200, 100, 200, 200', 150, 15 0));

	35 assert_false(CheckPointInArea('poly', '100, 100, 200, 100, 200, 200', 100, 1 50));

	36 assert_false(CheckPointInArea('poly', '100, 100, 200, 100, 200, 200', 300, 3 00));

	37 assert_true(CheckPointInArea('default', '', 300, 300));

	38 });

	39 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/images/imagemap-dynamic-area-updates-expected.txt » ('j') | no next file with comments »