Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6061)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.h

Issue 2255413002: [Signin Error Dialog] (3/3) Added the triggering code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleared up Get/SetLastLoginErrorEmail Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_service.h
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.h b/chrome/browser/ui/webui/signin/login_ui_service.h
index b6d070c53378b4f748eae7069f1b51277058a8f9..db8808362efbb0c24e30fa905ad105bcb573372d 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.h
+++ b/chrome/browser/ui/webui/signin/login_ui_service.h
@@ -79,12 +79,19 @@ class LoginUIService : public KeyedService {
// chrome://signin to ask the user to sign in to chrome.
void ShowLoginPopup();
+ // Sets the last email used for signing in when a signin error occured.
+ void SetLastLoginErrorUsername(const base::string16& username);
anthonyvd 2016/08/22 14:58:46 Since username == email here, maybe we should pick
Jane 2016/08/22 20:48:31 Done.
+
// Displays login results.
void DisplayLoginResult(Browser* browser, const base::string16& message);
// Gets the last login result set through |DisplayLoginResult|.
const base::string16& GetLastLoginResult();
+ // Gets the last email used for login when a login error occured; set through
+ // |SetLastLoginUsername|.
+ const base::string16& GetLastLoginErrorUsername();
anthonyvd 2016/08/22 14:58:46 Same as above.
Jane 2016/08/22 20:48:31 Done.
+
private:
// Weak pointers to the recently opened UIs, with the most recent in front.
std::list<LoginUI*> ui_list_;
@@ -96,6 +103,7 @@ class LoginUIService : public KeyedService {
base::ObserverList<Observer> observer_list_;
base::string16 last_login_result_;
+ base::string16 last_login_error_username_;
DISALLOW_COPY_AND_ASSIGN(LoginUIService);
};

Powered by Google App Engine
This is Rietveld 408576698