Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 2255413002: [Signin Error Dialog] (3/3) Added the triggering code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleared up Get/SetLastLoginErrorEmail Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
index b166898dd31cfd8164cb3e87515ac9806bd72958..f21cdd884e1e58441e6ac4b9ffdf2c93f8fb84bf 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
@@ -454,6 +454,8 @@ void InlineSigninHelper::ConfirmEmailAction(
void InlineSigninHelper::OnClientOAuthFailure(
const GoogleServiceAuthError& error) {
+ LoginUIServiceFactory::GetForProfile(profile_)->SetLastLoginErrorUsername(
+ base::string16());
if (handler_)
handler_->HandleLoginError(error.ToString());
@@ -780,6 +782,8 @@ void InlineLoginHandlerImpl::FinishCompleteLogin(
validate_email == "1") {
if (!gaia::AreEmailsSame(params.email, default_email)) {
if (params.handler) {
+ LoginUIServiceFactory::GetForProfile(profile)
+ ->SetLastLoginErrorUsername(base::UTF8ToUTF16(params.email));
params.handler->HandleLoginError(
l10n_util::GetStringFUTF8(IDS_SYNC_WRONG_EMAIL,
base::UTF8ToUTF16(default_email)));
@@ -824,8 +828,11 @@ void InlineLoginHandlerImpl::FinishCompleteLogin(
bool can_offer = CanOffer(profile, can_offer_for, params.gaia_id,
params.email, &error_msg);
if (!can_offer) {
- if (params.handler)
+ if (params.handler) {
+ LoginUIServiceFactory::GetForProfile(profile)->SetLastLoginErrorUsername(
+ base::UTF8ToUTF16(params.email));
params.handler->HandleLoginError(error_msg);
+ }
return;
}

Powered by Google App Engine
This is Rietveld 408576698