Create MouseEventManager and EventHandlingUtil

third_party/WebKit/Source/core/input/EventHandler.h

Index: third_party/WebKit/Source/core/input/EventHandler.h
diff --git a/third_party/WebKit/Source/core/input/EventHandler.h b/third_party/WebKit/Source/core/input/EventHandler.h
index 972a107b2fe7cf72ee3f4cf1b955420b85bfbe7e..16dd320d89136506f503e98efe1a41c63f69231a 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.h
+++ b/third_party/WebKit/Source/core/input/EventHandler.h
@@ -30,6 +30,7 @@
 #include "core/events/TextEventInputType.h"
 #include "core/input/GestureManager.h"
 #include "core/input/KeyboardEventManager.h"
+#include "core/input/MouseEventManager.h"
 #include "core/input/PointerEventManager.h"
 #include "core/input/ScrollManager.h"
 #include "core/layout/HitTestRequest.h"
@@ -111,8 +112,6 @@ public:
     void dispatchFakeMouseMoveEventSoon();
     void dispatchFakeMouseMoveEventSoonInQuad(const FloatQuad&);
 
-    static HitTestResult hitTestResultInFrame(LocalFrame*, const LayoutPoint&, HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active);
-
     HitTestResult hitTestResultAtPoint(const LayoutPoint&,
         HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active,
         const LayoutSize& padding = LayoutSize());
@@ -193,9 +192,6 @@ public:
 
     void setMouseDownMayStartAutoscroll() { m_mouseDownMayStartAutoscroll = true; }
 
-    static WebInputEventResult mergeEventResult(WebInputEventResult resultA, WebInputEventResult resultB);
-    static WebInputEventResult toWebInputEventResult(DispatchEventResult);
-
     bool handleAccessKey(const WebKeyboardEvent&);
     WebInputEventResult keyEvent(const WebKeyboardEvent&);
     void defaultKeyboardEventHandler(KeyboardEvent*);
@@ -217,8 +213,6 @@ public:
 
     PassRefPtr<UserGestureToken> takeLastMouseDownGestureToken() { return m_lastMouseDownUserGestureToken.release(); }
 
-    int clickCount() { return m_clickCount; }
-
     SelectionController& selectionController() const { return *m_selectionController; }
 
     // FIXME(nzolghadr): This function is technically a private function of
@@ -373,6 +367,7 @@ private:
     Member<Node> m_capturingMouseEventsNode;
     bool m_eventHandlerWillResetCapturingMouseEventsNode;
 
+    // TODO(nzolghadr): Refactor the mouse related fields to MouseEventManager.
     // Note the difference of this and m_nodeUnderPointer in PointerEventManager
     Member<Node> m_nodeUnderMouse;
 
@@ -396,9 +391,10 @@ private:
     PlatformMouseEvent m_mouseDown;
     RefPtr<UserGestureToken> m_lastMouseDownUserGestureToken;
 
-    PointerEventManager m_pointerEventManager;
     ScrollManager m_scrollManager;

[bokan, 2016/09/01 13:50:13]

I just realized, these classes have on-heap members, and we trace these classes
even though they're not held in Member/WeakMember handles nor do they inherit
from GarbageCollected. I suspect this may work but the Oilpan reference seems to
imply that tracing should only happen on garbage collected, on-heap members:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...

+haraken@: is it ok to be tracing non-GarbageCollected, non-handle members like
this?

[haraken, 2016/09/01 17:12:47]

You must trace these objects because they are a-part-of on-heap object (i.e.,
objects that have DISALLOW_NEW) and have members to be traced. They are not
GarbageCollected but a part of a GarbageCollected object (i.e., EventHandler).
So they need to be traced.

+    MouseEventManager m_mouseEventManager;
     KeyboardEventManager m_keyboardEventManager;
+    PointerEventManager m_pointerEventManager;
     GestureManager m_gestureManager;
 
     double m_maxMouseMovedDuration;