Create MouseEventManager and EventHandlingUtil

third_party/WebKit/Source/core/input/EventHandler.h

 /*
  * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef EventHandler_h
 #define EventHandler_h
 
 #include "core/CoreExport.h"
 #include "core/events/TextEventInputType.h"
 #include "core/input/GestureManager.h"
 #include "core/input/KeyboardEventManager.h"
+#include "core/input/MouseEventManager.h"
 #include "core/input/PointerEventManager.h"
 #include "core/input/ScrollManager.h"
 #include "core/layout/HitTestRequest.h"
 #include "core/page/DragActions.h"
 #include "core/page/EventWithHitTestResults.h"
 #include "core/style/ComputedStyleConstants.h"
 #include "platform/Cursor.h"
 #include "platform/PlatformMouseEvent.h"
 #include "platform/PlatformTouchPoint.h"
 #include "platform/Timer.h"
@@ skipping 61 matching lines @@
     // TODO(nzolghadr): Some of the APIs in this class only forward the action
     // to the corresponding Manager class. We need to investigate whether it is
     // better to expose the manager instance itself later or can the access to
     // those APIs be more limited or removed.
 
     void stopAutoscroll();
 
     void dispatchFakeMouseMoveEventSoon();
     void dispatchFakeMouseMoveEventSoonInQuad(const FloatQuad&);
 
-    static HitTestResult hitTestResultInFrame(LocalFrame*, const LayoutPoint&, HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active);
-
     HitTestResult hitTestResultAtPoint(const LayoutPoint&,
         HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active,
         const LayoutSize& padding = LayoutSize());
 
     bool mousePressed() const { return m_mousePressed; }
 
     void setCapturingMouseEventsNode(Node*); // A caller is responsible for resetting capturing node to 0.
 
     WebInputEventResult updateDragAndDrop(const PlatformMouseEvent&, DataTransfer*);
     void cancelDragAndDrop(const PlatformMouseEvent&, DataTransfer*);
@@ skipping 60 matching lines @@
 
     void setPointerCapture(int, EventTarget*);
     void releasePointerCapture(int, EventTarget*);
     bool hasPointerCapture(int, const EventTarget*) const;
     bool hasProcessedPointerCapture(int, const EventTarget*) const;
 
     void elementRemoved(EventTarget*);
 
     void setMouseDownMayStartAutoscroll() { m_mouseDownMayStartAutoscroll = true; }
 
-    static WebInputEventResult mergeEventResult(WebInputEventResult resultA, WebInputEventResult resultB);
-    static WebInputEventResult toWebInputEventResult(DispatchEventResult);
-
     bool handleAccessKey(const WebKeyboardEvent&);
     WebInputEventResult keyEvent(const WebKeyboardEvent&);
     void defaultKeyboardEventHandler(KeyboardEvent*);
 
     bool handleTextInputEvent(const String& text, Event* underlyingEvent = nullptr, TextEventInputType = TextEventInputKeyboard);
     void defaultTextInputEventHandler(TextEvent*);
 
     void dragSourceEndedAt(const PlatformMouseEvent&, DragOperation);
 
     void focusDocumentView();
 
     void capsLockStateMayHaveChanged(); // Only called by FrameSelection
 
     WebInputEventResult handleTouchEvent(const PlatformTouchEvent&);
 
     bool useHandCursor(Node*, bool isOverLink);
 
     void notifyElementActivated();
 
     PassRefPtr<UserGestureToken> takeLastMouseDownGestureToken() { return m_lastMouseDownUserGestureToken.release(); }
 
-    int clickCount() { return m_clickCount; }
-
     SelectionController& selectionController() const { return *m_selectionController; }
 
     // FIXME(nzolghadr): This function is technically a private function of
     // EventHandler class. Making it public temporary to make it possible to
     // move some code around in the refactoring process.
     // Performs a chaining logical scroll, within a *single* frame, starting
     // from either a provided starting node or a default based on the focused or
     // most recently clicked node, falling back to the frame.
     // Returns true if the scroll was consumed.
     // direction - The logical direction to scroll in. This will be converted to
@@ skipping 134 matching lines @@
 
     bool m_mouseDownMayStartAutoscroll;
 
     Timer<EventHandler> m_fakeMouseMoveEventTimer;
 
     bool m_svgPan;
 
     Member<Node> m_capturingMouseEventsNode;
     bool m_eventHandlerWillResetCapturingMouseEventsNode;
 
+    // TODO(nzolghadr): Refactor the mouse related fields to MouseEventManager.
     // Note the difference of this and m_nodeUnderPointer in PointerEventManager
     Member<Node> m_nodeUnderMouse;
 
     Member<LocalFrame> m_lastMouseMoveEventSubframe;
     Member<Scrollbar> m_lastScrollbarUnderMouse;
 
     int m_clickCount;
     Member<Node> m_clickNode;
 
     Member<Node> m_dragTarget;
     bool m_shouldOnlyFireDragOverEvent;
 
     Member<HTMLFrameSetElement> m_frameSetBeingResized;
 
     bool m_mousePositionIsUnknown;
     // The last mouse movement position this frame has seen in root frame coordinates.
     IntPoint m_lastKnownMousePosition;
     IntPoint m_lastKnownMouseGlobalPosition;
     IntPoint m_mouseDownPos; // In our view's coords.
     double m_mouseDownTimestamp;
     PlatformMouseEvent m_mouseDown;
     RefPtr<UserGestureToken> m_lastMouseDownUserGestureToken;
 
+    ScrollManager m_scrollManager;

[bokan, 2016/09/01 13:50:13]

I just realized, these classes have on-heap members, and we trace these classes
even though they're not held in Member/WeakMember handles nor do they inherit
from GarbageCollected. I suspect this may work but the Oilpan reference seems to
imply that tracing should only happen on garbage collected, on-heap members:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...

+haraken@: is it ok to be tracing non-GarbageCollected, non-handle members like
this?

[haraken, 2016/09/01 17:12:47]

You must trace these objects because they are a-part-of on-heap object (i.e.,
objects that have DISALLOW_NEW) and have members to be traced. They are not
GarbageCollected but a part of a GarbageCollected object (i.e., EventHandler).
So they need to be traced.

+    MouseEventManager m_mouseEventManager;
+    KeyboardEventManager m_keyboardEventManager;
     PointerEventManager m_pointerEventManager;
-    ScrollManager m_scrollManager;
-    KeyboardEventManager m_keyboardEventManager;
     GestureManager m_gestureManager;
 
     double m_maxMouseMovedDuration;
 
     bool m_longTapShouldInvokeContextMenu;
 
     Timer<EventHandler> m_activeIntervalTimer;
     double m_lastShowPressTimestamp;
     Member<Element> m_lastDeferredTapElement;
 
     // Set on GestureTapDown if the |pointerdown| event corresponding to the
     // triggering |touchstart| event was canceled. This suppresses mouse event
     // firing for the current gesture sequence (i.e. until next GestureTapDown).
     bool m_suppressMouseEventsFromGestures;
 
     // TODO(nzolghadr): Temporary until further refactoring
     friend GestureManager;
 };
 
 } // namespace blink
 
 #endif // EventHandler_h