Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: appengine/findit/templates/flake/result.html

Issue 2255293003: [Findit] On hover over, shows pass rate for a swarming rerun (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/templates/flake/result.html
diff --git a/appengine/findit/templates/flake/result.html b/appengine/findit/templates/flake/result.html
index 7713dffaaa23376d3b2fa17115c254c4620099b1..6555e95436f660894e1d4c38392e608e443ef435 100644
--- a/appengine/findit/templates/flake/result.html
+++ b/appengine/findit/templates/flake/result.html
@@ -29,8 +29,30 @@
labelBoxBorderColor: "none",
position: "right"
}
- }
- )});
+ })
stgao 2016/08/19 04:14:04 nit: end with ";"?
caiw 2016/08/19 18:24:11 Done.
+ $("<div id='tooltip'></div>").css({
+ position: "absolute",
+ display: "none",
+ border: "1px solid #fdd",
+ padding: "2px",
+ "background-color": "#fee",
+ opacity: 0.80
+ }).appendTo("body");
+
+
+ $("#placeholder").bind("plothover", function (event, pos, item) {
stgao 2016/08/19 04:22:13 Currently, it is hard to tell where data points ar
caiw 2016/08/19 18:24:11 Done.
+ if (item) {
+ var x = Math.round(item.datapoint[0].toFixed(2)),
+ y = item.datapoint[1].toFixed(2);
stgao 2016/08/19 04:14:04 nit: one statement in one line.
caiw 2016/08/19 18:24:11 Done.
+
+ $("#tooltip").html("Build Number " + x + " has a pass rate of " + y)
stgao 2016/08/19 04:14:04 How about this format instead? Build Number: XXXX
caiw 2016/08/19 18:24:11 Done.
+ .css({top: item.pageY+5, left: item.pageX+5})
+ .fadeIn(200);
+ }
+ else {
+ $("#tooltip").hide();
+ }
+ })});
</script>
</head>
@@ -40,6 +62,11 @@
<td></td>
<td>
<h1>Regression range of Test</h1>
+ Status of Analysis: {{analysis_status}}
+ {% if suspected_flake_build_number %}
+ <br>
+ Suspected Build Number of Culprit: {{suspected_flake_build_number}}
stgao 2016/08/19 04:14:04 Wording nit: "Suspected Build Number of Culprit:"
caiw 2016/08/19 18:24:11 Done.
+ {% endif %}
</td>
<td></td>
</tr>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698