Chromium Code Reviews Chromium Code Reviews
Issue 2255293003:
[Findit] On hover over, shows pass rate for a swarming rerun (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <head> | 2 <head> |
| 3 <meta charset="UTF-8"> | 3 <meta charset="UTF-8"> |
| 4 <title> Find Regression Range</title> | 4 <title> Find Regression Range</title> |
| 5 <style type="text/css"> | 5 <style type="text/css"> |
| 6 body { | 6 body { |
| 7 font-family: Verdana, Arial, sans-serif; | 7 font-family: Verdana, Arial, sans-serif; |
| 8 font-size: 12px; | 8 font-size: 12px; |
| 9 } | 9 } |
| 10 #placeholder { | 10 #placeholder { |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 22 $.plot($("#placeholder"), [{{success_rates}}], | 22 $.plot($("#placeholder"), [{{success_rates}}], |
| 23 { | 23 { |
| 24 grid: { | 24 grid: { |
| 25 hoverable: true, | 25 hoverable: true, |
| 26 borderWidth: 1 | 26 borderWidth: 1 |
| 27 }, | 27 }, |
| 28 legend: { | 28 legend: { |
| 29 labelBoxBorderColor: "none", | 29 labelBoxBorderColor: "none", |
| 30 position: "right" | 30 position: "right" |
| 31 } | 31 } |
| 32 } | 32 }) |
|
stgao
2016/08/19 04:14:04
nit: end with ";"?
caiw
2016/08/19 18:24:11
Done.
| |
| 33 )}); | 33 $("<div id='tooltip'></div>").css({ |
| 34 position: "absolute", | |
| 35 display: "none", | |
| 36 border: "1px solid #fdd", | |
| 37 padding: "2px", | |
| 38 "background-color": "#fee", | |
| 39 opacity: 0.80 | |
| 40 }).appendTo("body"); | |
| 41 | |
| 42 | |
| 43 $("#placeholder").bind("plothover", function (event, pos, item) { | |
|
stgao
2016/08/19 04:22:13
Currently, it is hard to tell where data points ar
caiw
2016/08/19 18:24:11
Done.
| |
| 44 if (item) { | |
| 45 var x = Math.round(item.datapoint[0].toFixed(2)), | |
| 46 y = item.datapoint[1].toFixed(2); | |
|
stgao
2016/08/19 04:14:04
nit: one statement in one line.
caiw
2016/08/19 18:24:11
Done.
| |
| 47 | |
| 48 $("#tooltip").html("Build Number " + x + " has a pass rate of " + y) | |
|
stgao
2016/08/19 04:14:04
How about this format instead?
Build Number: XXXX
caiw
2016/08/19 18:24:11
Done.
| |
| 49 .css({top: item.pageY+5, left: item.pageX+5}) | |
| 50 .fadeIn(200); | |
| 51 } | |
| 52 else { | |
| 53 $("#tooltip").hide(); | |
| 54 } | |
| 55 })}); | |
| 34 </script> | 56 </script> |
| 35 </head> | 57 </head> |
| 36 | 58 |
| 37 <body> | 59 <body> |
|
stgao
2016/08/19 04:14:04
It seems a good idea to show the master name/ buil
caiw
2016/08/19 18:24:11
Done.
| |
| 38 <table> | 60 <table> |
| 39 <tr> | 61 <tr> |
| 40 <td></td> | 62 <td></td> |
| 41 <td> | 63 <td> |
| 42 <h1>Regression range of Test</h1> | 64 <h1>Regression range of Test</h1> |
| 65 Status of Analysis: {{analysis_status}} | |
| 66 {% if suspected_flake_build_number %} | |
| 67 <br> | |
| 68 Suspected Build Number of Culprit: {{suspected_flake_build_number}} | |
|
stgao
2016/08/19 04:14:04
Wording nit: "Suspected Build Number of Culprit:"
caiw
2016/08/19 18:24:11
Done.
| |
| 69 {% endif %} | |
| 43 </td> | 70 </td> |
| 44 <td></td> | 71 <td></td> |
| 45 </tr> | 72 </tr> |
| 46 <tr> | 73 <tr> |
| 47 <td>Pass Rate</td> | 74 <td>Pass Rate</td> |
| 48 <td> | 75 <td> |
| 49 <div id="placeholder"></div> | 76 <div id="placeholder"></div> |
| 50 </td> | 77 </td> |
| 51 <td></td> | 78 <td></td> |
| 52 </tr> | 79 </tr> |
| 53 <tr> | 80 <tr> |
| 54 <td></td> | 81 <td></td> |
| 55 <td>Build Number</td> | 82 <td>Build Number</td> |
| 56 <td></td> | 83 <td></td> |
| 57 </tr> | 84 </tr> |
| 58 </table> | 85 </table> |
| 59 </body> | 86 </body> |
| 60 </html> | 87 </html> |
| OLD | NEW |
