Fast path translate() in SkCanvas and SkLiteDL.

Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed: https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout

Problem is FMA vs. not.

CQ_INCLUDE_TRYBOTS=master.client.skia:
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot

Committed: https://skia.googlesource.com/skia/+/cbdf007bc2eb85056a1a5c75c088202becba2d16

[mtklein_C, 2016-08-18 18:01:33]

Description was changed from

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
==========

to

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002
==========

[mtklein_C, 2016-08-18 18:01:43]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:01:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-18 18:03:19]

mtklein@chromium.org changed reviewers:
+ herb@google.com, reed@google.com

[commit-bot: I haz the power, 2016-08-18 18:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:12:17]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein, 2016-08-18 18:16:17]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein_C, 2016-08-18 18:50:04]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:50:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 19:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 19:14:09]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-08-18 19:28:18]

https://codereview.chromium.org/2255283002/diff/1/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/2255283002/diff/1/src/core/SkMatrix.cpp#newco...
src/core/SkMatrix.cpp:297: SkASSERT(kTranslate_Mask == this->computeTypeMask());
This could fail if the translate sent those fields to zero -- we'd be
identity...

[mtklein_C, 2016-08-18 19:35:59]

https://codereview.chromium.org/2255283002/diff/1/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/2255283002/diff/1/src/core/SkMatrix.cpp#newco...
src/core/SkMatrix.cpp:297: SkASSERT(kTranslate_Mask == this->computeTypeMask());
On 2016/08/18 at 19:28:18, reed1 wrote:
> This could fail if the translate sent those fields to zero -- we'd be
identity...

Good catch.  Fixed.

[mtklein_C, 2016-08-18 19:36:02]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:36:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-18 19:39:42]

On 2016/08/18 at 19:35:59, mtklein_C wrote:
> https://codereview.chromium.org/2255283002/diff/1/src/core/SkMatrix.cpp
> File src/core/SkMatrix.cpp (right):
> 
>
https://codereview.chromium.org/2255283002/diff/1/src/core/SkMatrix.cpp#newco...
> src/core/SkMatrix.cpp:297: SkASSERT(kTranslate_Mask ==
this->computeTypeMask());
> On 2016/08/18 at 19:28:18, reed1 wrote:
> > This could fail if the translate sent those fields to zero -- we'd be
identity...
> 
> Good catch.  Fixed.

Sorry, jumped the gun on that.  I think PS 4 is more likely the fix you were
looking to see.

[mtklein_C, 2016-08-18 19:39:45]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:39:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 20:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:03:33]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-08-18 21:22:20]

a unittest might prove me wrong about the assert...

SkMatrix m;

m.setTranslate(1, 2);
m.getType();
m.preTranslate(-1, -2);
m.getType();

https://codereview.chromium.org/2255283002/diff/60001/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/2255283002/diff/60001/src/core/SkMatrix.cpp#n...
src/core/SkMatrix.cpp:296: this->setTypeMask(kTranslate_Mask);
I *think* we can assert that the matrix is mislabeled if in fact it is
identity... Its possibly you need to actually check the resulting 2 floats and
set this bit conditionally.

[mtklein, 2016-08-18 21:36:07]

On 2016/08/18 21:22:20, reed1 wrote:
> a unittest might prove me wrong about the assert...
> 
> SkMatrix m;
> 
> m.setTranslate(1, 2);
> m.getType();
> m.preTranslate(-1, -2);
> m.getType();
> 
> https://codereview.chromium.org/2255283002/diff/60001/src/core/SkMatrix.cpp
> File src/core/SkMatrix.cpp (right):
> 
>
https://codereview.chromium.org/2255283002/diff/60001/src/core/SkMatrix.cpp#n...
> src/core/SkMatrix.cpp:296: this->setTypeMask(kTranslate_Mask);
> I *think* we can assert that the matrix is mislabeled if in fact it is
> identity... Its possibly you need to actually check the resulting 2 floats and
> set this bit conditionally.

Should be good for a last look.
Also rebased on Matt's change in SkCanvas.cpp.

[mtklein_C, 2016-08-18 21:36:18]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 21:36:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-08-18 21:58:16]

lgtm

[mtklein_C, 2016-08-18 22:03:10]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-08-18 22:03:12]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-18 22:04:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 22:42:35]

Description was changed from

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002
==========

to

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c
==========

[commit-bot: I haz the power, 2016-08-18 22:42:36]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

[mtklein, 2016-08-19 00:26:10]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2264433002/ by mtklein@google.com.

The reason for reverting is: speculative.

[mtklein_C, 2016-08-19 00:44:10]

Description was changed from

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c
==========

to

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout
==========

[mtklein, 2016-08-19 14:41:15]

Description was changed from

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout
==========

to

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout
==========

[mtklein_C, 2016-08-19 15:16:52]

Description was changed from

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout
==========

to

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout

Problem is FMA vs. not.
==========

[mtklein_C, 2016-08-19 15:42:51]

Description was changed from

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout

Problem is FMA vs. not.
==========

to

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout

Problem is FMA vs. not.

CQ_INCLUDE_TRYBOTS=master.client.skia:
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot
==========

[mtklein_C, 2016-08-19 15:42:59]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-08-19 15:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2255283002/#ps100001
(title: "plumb translate() through to SkRecord too")

[commit-bot: I haz the power, 2016-08-19 15:43:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 16:05:29]

Description was changed from

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout

Problem is FMA vs. not.

CQ_INCLUDE_TRYBOTS=master.client.skia:
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot
==========

to

==========
Fast path translate() in SkCanvas and SkLiteDL.

This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.

It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002

Committed:
https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c

Misc bots failing in pictureimagefilter replay modes.
https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout

Problem is FMA vs. not.

CQ_INCLUDE_TRYBOTS=master.client.skia:
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot

Committed:
https://skia.googlesource.com/skia/+/cbdf007bc2eb85056a1a5c75c088202becba2d16
==========

[commit-bot: I haz the power, 2016-08-19 16:05:30]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/cbdf007bc2eb85056a1a5c75c088202becba2d16