Issue 225513004: Fix power measurement with dumpsys when the format is unrecognized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225513004: Fix power measurement with dumpsys when the format is unrecognized. (Closed)

Created:
6 years, 8 months ago by qsr

Modified:
6 years, 8 months ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix power measurement with dumpsys when the format is unrecognized. dumpsys information for older release of android doesn't contain the needed information. This CL prevent the application to crash in that case. BUG=359883 TBR=tonyg@chromium.org This is a reland of https://codereview.chromium.org/225493003 with the missing data file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261765

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1546 lines, -5 lines)			Patch
M	tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py	View	4 chunks	+10 lines, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	tools/telemetry/unittest_data/batterystats_v7_no_data.csv	View	1 chunk	+1524 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/225513004/1

6 years, 8 months ago (2014-04-04 10:49:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/225513004/1

6 years, 8 months ago (2014-04-04 15:24:13 UTC) #3

Message was sent while issue was closed.

Change committed as 261765