Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 225493003: Fix power measurement with dumpsys when the format is unrecognized. (Closed)

Created:
6 years, 8 months ago by qsr
Modified:
6 years, 8 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Fix power measurement with dumpsys when the format is unrecognized. dumpsys information for older release of android doesn't contain the needed information. This CL prevent the application to crash in that case. BUG=359883 TBR=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 4 chunks +10 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qsr
6 years, 8 months ago (2014-04-04 08:32:17 UTC) #1
qsr
Committed patchset #1 manually as r261708 (presubmit successful).
6 years, 8 months ago (2014-04-04 08:33:20 UTC) #2
nhiroki
A revert of this CL has been created in https://codereview.chromium.org/225683002/ by nhiroki@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-04 10:22:25 UTC) #3
Nikita (slow)
On 2014/04/04 08:33:20, qsr wrote: > Committed patchset #1 manually as r261708 (presubmit successful). No ...
6 years, 8 months ago (2014-04-04 10:23:02 UTC) #4
Nikita (slow)
A revert of this CL has been created in https://codereview.chromium.org/225693002/ by nkostylev@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-04 10:23:23 UTC) #5
qsr
6 years, 8 months ago (2014-04-04 10:48:27 UTC) #6
Message was sent while issue was closed.
On 2014/04/04 10:23:23, Nikita Kostylev wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/225693002/ by mailto:nkostylev@chromium.org.
> 
> The reason for reverting is: Breaks buildbots (and trybots)
> http://goo.gl/a2DGKW
> http://goo.gl/FX2KBP
> http://goo.gl/6vvIHR.

 A stupid one -> this was to fix the perf waterfall...

Powered by Google App Engine
This is Rietveld 408576698