Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: ios/chrome/browser/signin/constants.h

Issue 2254813002: Remove SignInSource from ShowSigninCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@signin_source
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/commands/show_signin_command.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/signin/constants.h
diff --git a/ios/chrome/browser/signin/constants.h b/ios/chrome/browser/signin/constants.h
index 2ff5f98785cb4d450f8e7f22394a420cea28e117..1b30eeabeddf7f11ebdabeeb90ff9f7074655e41 100644
--- a/ios/chrome/browser/signin/constants.h
+++ b/ios/chrome/browser/signin/constants.h
@@ -24,40 +24,6 @@ typedef enum {
TIMED_OUT_FETCH_POLICY = -210,
} AuthenticationErrorCode;
-// Enum is used to count the various sign in sources in the histogram
-// |Signin.IOSSignInSource|.
-typedef enum {
- // Unspecified sign-in source. This includes sign in operations started from
- // "Other Devices" and from the sync error infobar displayed for pre-SSO
- // signed in users.
- SIGN_IN_SOURCE_OTHER,
- // Sign in operation was started from first run.
- SIGN_IN_SOURCE_FIRST_RUN,
- // Sign in operation was started from the SSO recall promo.
- SIGN_IN_SOURCE_SSO_PROMO,
- // Sign in operation was started from settings.
- SIGN_IN_SOURCE_SETTINGS,
- // Sign in operation was started from as a pre-requisite of share operation.
- // Deprecated since M53.
- SIGN_IN_SOURCE_SHARE_DEPRECATED,
- // Sign in operation was started from as a pre-requisite of a print operation.
- SIGN_IN_SOURCE_PRINT,
- // Sign in operation was started from the re-sign in infobar.
- SIGN_IN_SOURCE_RESIGN_IN_INFOBAR,
- // Sign in operation was started from the Chrome to Device infobar.
- SIGN_IN_SOURCE_CHROME_TO_DEVICE_INFOBAR,
- // Sign in operation was started from the recent tabs panel.
- SIGN_IN_SOURCE_RECENT_TABS,
- // Sign in operation was started from the bookmarks promo panel.
- SIGN_IN_SOURCE_BOOKMARKS_PROMO,
- // Sign in operation was started from the Tab Switcher.
- SIGN_IN_SOURCE_TAB_SWITCHER,
- // NOTE: Add new sign in sources only immediately above this line. Also, make
- // sure the enum list for histogram |Signin.IOSSignInSource| in
- // uma/configs/chrome/histograms.xml is updated with any change in here.
- SIGN_IN_SOURCE_COUNT
-} SignInSource;
-
typedef enum {
SHOULD_CLEAR_DATA_USER_CHOICE,
SHOULD_CLEAR_DATA_CLEAR_DATA,
« no previous file with comments | « no previous file | ios/chrome/browser/ui/commands/show_signin_command.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698