Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: Source/devtools/front_end/DOMAgent.js

Issue 22548006: DevTools: Improve performance of the element breadcrumbs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed the test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/elements/breadcrumb-updates.html ('k') | Source/devtools/front_end/ElementsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/DOMAgent.js
diff --git a/Source/devtools/front_end/DOMAgent.js b/Source/devtools/front_end/DOMAgent.js
index 63abcf43cdedfc98fb726d734dcf0c41c42d4648..3f948b9ce6eb7103d79cd119924fcc4fc391067d 100644
--- a/Source/devtools/front_end/DOMAgent.js
+++ b/Source/devtools/front_end/DOMAgent.js
@@ -364,7 +364,7 @@ WebInspector.DOMNode.prototype = {
},
/**
- * @param {function(?Protocol.Error)=} callback
+ * @param {function(?Protocol.Error, DOMAgent.NodeId=)=} callback
*/
removeNode: function(callback)
{
@@ -596,7 +596,7 @@ WebInspector.DOMNode.prototype = {
/**
* @param {WebInspector.DOMNode} targetNode
* @param {?WebInspector.DOMNode} anchorNode
- * @param {function(?Protocol.Error)=} callback
+ * @param {function(?Protocol.Error, DOMAgent.NodeId=)=} callback
*/
moveTo: function(targetNode, anchorNode, callback)
{
@@ -830,9 +830,11 @@ WebInspector.DOMDocument.prototype = {
* @constructor
*/
WebInspector.DOMAgent = function() {
- /** @type {Object|undefined} */
+ /** @type {!Object.<number, !WebInspector.DOMNode>} */
this._idToDOMNode = {};
+ /** @type {?WebInspector.DOMDocument} */
this._document = null;
+ /** @type {!Object.<number, boolean>} */
this._attributeLoadNodeIds = {};
InspectorBackend.registerDOMDispatcher(new WebInspector.DOMDispatcher(this));
}
@@ -1349,8 +1351,9 @@ WebInspector.DOMAgent.prototype = {
/**
* @param {WebInspector.DOMNode} node
- * @param {function(?Protocol.Error)=} callback
- * @return {function(?Protocol.Error)}
+ * @param {function(?Protocol.Error, A=, B=)=} callback
+ * @return {function(?Protocol.Error, A=, B=)}
+ * @template A,B
*/
_markRevision: function(node, callback)
{
« no previous file with comments | « LayoutTests/inspector/elements/breadcrumb-updates.html ('k') | Source/devtools/front_end/ElementsPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698