DevTools: Improve performance of the element breadcrumbs.

DevTools: Improve performance of the element breadcrumbs.

BUG=237447, 269067
R=pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156551

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156560

[pfeldman, 2013-08-07 12:04:21]

Adding even more complexity into the code that creates unprecedented layout
thrashing is a no go.

[aandrey, 2013-08-08 08:30:31]

On 2013/08/07 12:04:21, pfeldman wrote:
> Adding even more complexity into the code that creates unprecedented layout
> thrashing is a no go.

Pavel,
If we decide to leave with the existing implementation until the next version of
breadcrumbs (https://code.google.com/p/chromium/issues/detail?id=269749), do you
think this patch is a good intermediate fix to the perf problems? I think we
could tolerate "adding even more complexity into the code" that will be thrown
away finally.

[aandrey, 2013-08-21 11:50:39]

revisited. ptal.

[pfeldman, 2013-08-21 17:16:32]

lgtm

https://codereview.chromium.org/22548006/diff/6001/Source/devtools/front_end/...
File Source/devtools/front_end/ElementsTreeOutline.js (right):

https://codereview.chromium.org/22548006/diff/6001/Source/devtools/front_end/...
Source/devtools/front_end/ElementsTreeOutline.js:78: DOMNodesUpdated:
"DOMNodesUpdated"
ElementsTreeUpdated

https://codereview.chromium.org/22548006/diff/6001/Source/devtools/front_end/...
Source/devtools/front_end/ElementsTreeOutline.js:274: _domNodesUpdated:
function(nodes)
_fireElementsTreeUpdated

https://codereview.chromium.org/22548006/diff/6001/Source/devtools/front_end/...
Source/devtools/front_end/ElementsTreeOutline.js:666: _selectNodeAfterEdit:
function(wasExpanded, error, nodeId)
Thanks.

[aandrey, 2013-08-21 17:30:01]

https://codereview.chromium.org/22548006/diff/6001/Source/devtools/front_end/...
File Source/devtools/front_end/ElementsTreeOutline.js (right):

https://codereview.chromium.org/22548006/diff/6001/Source/devtools/front_end/...
Source/devtools/front_end/ElementsTreeOutline.js:78: DOMNodesUpdated:
"DOMNodesUpdated"
On 2013/08/21 17:16:32, pfeldman wrote:
> ElementsTreeUpdated

Done.

https://codereview.chromium.org/22548006/diff/6001/Source/devtools/front_end/...
Source/devtools/front_end/ElementsTreeOutline.js:274: _domNodesUpdated:
function(nodes)
On 2013/08/21 17:16:32, pfeldman wrote:
> _fireElementsTreeUpdated

Done.

[commit-bot: I haz the power, 2013-08-21 17:32:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/22548006/12001

[commit-bot: I haz the power, 2013-08-21 18:10:14]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-08-21 18:56:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/22548006/12001

[commit-bot: I haz the power, 2013-08-21 20:17:03]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[aandrey, 2013-08-22 08:10:02]

Committed patchset #3 manually as r156551 (presubmit successful).

[commit-bot: I haz the power, 2013-08-22 12:34:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/22548006/32001

[commit-bot: I haz the power, 2013-08-22 14:07:22]

Change committed as 156560