arc: avoid checkbox AutomationNode issue

arc: avoid checkbox AutomationNode issue

Avoid checkbox AutomationNode issue https://crbug.com/638498

BUG=638501
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
Cr-Commit-Position: refs/heads/master@{#412740}

[yawano, 2016-08-17 06:58:49]

Description was changed from

==========
arc: avoid checkbox AutomationNode issue

Avoid checkbox AutomationNode issue https://crbug.com/638498

BUG=638501
BUG=b/30906810
TEST=tested as described in the issue
==========

to

==========
arc: avoid checkbox AutomationNode issue

Avoid checkbox AutomationNode issue https://crbug.com/638498

BUG=638501
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yawano, 2016-08-17 07:00:36]

yawano@chromium.org changed reviewers:
+ xiyuan@chromium.org

[yawano, 2016-08-17 07:00:37]

xiyuan@: PTAL. Thank you!

[xiyuan, 2016-08-17 17:32:46]

lgtm

[khmel, 2016-08-17 23:24:38]

On 2016/08/17 17:32:46, xiyuan wrote:
> lgtm

This change more likely will introduce regression witch checkbox sizes. Please
check before submiting

[khmel, 2016-08-17 23:24:50]

khmel@chromium.org changed reviewers:
+ khmel@chromium.org

[khmel, 2016-08-17 23:24:50]

khmel@chromium.org changed reviewers:
+ khmel@chromium.org

[khmel, 2016-08-17 23:24:50]

https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/arc_support/main.html (left):

https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/arc_support/main.html:66: <div
class="checkbox-container" id="enable-metrics-container" hidden>
Div is required here, please see my comment:
https://codereview.chromium.org/2179803002/diff/20001/chrome/browser/resource...

I found weird behavior when size of checkbox depends on number of lines in text
description. This makes checkbox with declared 16px in css file appeared as 12px
checkbox for 2 lines and 8px for 3 lines text description
(https://drive.google.com/a/google.com/file/d/0B63tZNwdjs-qejg3dEMwek9TLVk/vie...).
It was also not possible to apply padding because it was ignored. I found
workaround by wrapping checkbox by div.

[yawano, 2016-08-17 23:54:06]

https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/arc_support/main.html (left):

https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/arc_support/main.html:66: <div
class="checkbox-container" id="enable-metrics-container" hidden>
Does it happen with myCL? That's the reason I've added flex-shrink to the input
element. I saw it without flex-shrink, but I don't see it with flex-shrink.

IIUC, it happens since the size of input element is adjusted based on the size
of the text. Specifying flex-shrink: 0 should prevent it.

Also I've used margin to the input element in this CL instead of padding.

[khmel, 2016-08-17 23:55:56]

On 2016/08/17 23:54:06, yawano wrote:
>
https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/arc_support/main.html (left):
> 
>
https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/arc_support/main.html:66: <div
> class="checkbox-container" id="enable-metrics-container" hidden>
> Does it happen with myCL? That's the reason I've added flex-shrink to the
input
> element. I saw it without flex-shrink, but I don't see it with flex-shrink.
> 
> IIUC, it happens since the size of input element is adjusted based on the size
> of the text. Specifying flex-shrink: 0 should prevent it.
> 
> Also I've used margin to the input element in this CL instead of padding.

OK, if it is not reproducible. Thanks for handling this.
lgtm

[yawano, 2016-08-18 00:01:40]

On 2016/08/17 23:55:56, khmel wrote:
> On 2016/08/17 23:54:06, yawano wrote:
> >
>
https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
> > File chrome/browser/resources/chromeos/arc_support/main.html (left):
> > 
> >
>
https://codereview.chromium.org/2254673003/diff/1/chrome/browser/resources/ch...
> > chrome/browser/resources/chromeos/arc_support/main.html:66: <div
> > class="checkbox-container" id="enable-metrics-container" hidden>
> > Does it happen with myCL? That's the reason I've added flex-shrink to the
> input
> > element. I saw it without flex-shrink, but I don't see it with flex-shrink.
> > 
> > IIUC, it happens since the size of input element is adjusted based on the
size
> > of the text. Specifying flex-shrink: 0 should prevent it.
> > 
> > Also I've used margin to the input element in this CL instead of padding.
> 
> OK, if it is not reproducible. Thanks for handling this.
> lgtm

Thank you!

[yawano, 2016-08-18 00:01:46]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2016-08-18 00:02:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 04:07:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 04:08:39]

Description was changed from

==========
arc: avoid checkbox AutomationNode issue

Avoid checkbox AutomationNode issue https://crbug.com/638498

BUG=638501
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
arc: avoid checkbox AutomationNode issue

Avoid checkbox AutomationNode issue https://crbug.com/638498

BUG=638501
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
Cr-Commit-Position: refs/heads/master@{#412740}
==========

[commit-bot: I haz the power, 2016-08-18 04:08:40]

Patchset 1 (id:??) landed as
https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
Cr-Commit-Position: refs/heads/master@{#412740}

[yawano, 2016-08-18 08:12:53]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2257073002/ by yawano@chromium.org.

The reason for reverting is: https://crbug.com/638840.