chrome/browser/resources/chromeos/arc_support/main.html - Issue 2179803002: arc: Use location service consent.

Side by Side Diff: chrome/browser/resources/chromeos/arc_support/main.html

Issue 2179803002: arc: Use location service consent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebae Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <link rel="stylesheet" href="chrome://resources/css/roboto.css">	4 <link rel="stylesheet" href="chrome://resources/css/roboto.css">

5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-bu tton.html">	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-bu tton.html">

6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-progress/paper- progress.html">	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-progress/paper- progress.html">

7 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/clas ses/iron-flex-layout.html">	7 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/clas ses/iron-flex-layout.html">

8 <style is="custom-style">	8 <style is="custom-style">

9 paper-progress {	9 paper-progress {

10 display: block;	10 display: block;

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 <img class="image-header" src="images/header.png">	56 <img class="image-header" src="images/header.png">

57 <div class="scrollable" >	57 <div class="scrollable" >

58 <div class="content section-flex">	58 <div class="content section-flex">

59 <p class="text-title" i18n-content="greetingHeader"></p>	59 <p class="text-title" i18n-content="greetingHeader"></p>

60 <p class="text-desc" i18n-content="greetingDescription"></p>	60 <p class="text-desc" i18n-content="greetingDescription"></p>

61 <p class="text-terms-title" i18n-content="termsOfService"></p>	61 <p class="text-terms-title" i18n-content="termsOfService"></p>

62 <div class="section-terms" id ="terms-container">	62 <div class="section-terms" id ="terms-container">

63 <webview id="terms-view" partition="persist:arc_support"></webview>	63 <webview id="terms-view" partition="persist:arc_support"></webview>

64 </div>	64 </div>

65 <div class="layout horizontal section-checkbox-container">	65 <div class="layout horizontal section-checkbox-container">

66 <input type="checkbox" class="checkbox-option" id="enable-metrics"	66 <div class="checkbox-container">
	khmel 2016/07/25 15:36:05 I found weird behavior when size of checkbox depen I found weird behavior when size of checkbox depends on number of lines in text description. This makes checkbox with declared 16px in css file appeared as 12px checkbox for 2 lines and 8px for 3 lines text description (https://drive.google.com/a/google.com/file/d/0B63tZNwdjs-qejg3dEMwek9TLVk/vie...). It was also not possible to apply padding because it was ignored. I found workaround by wrapping checkbox by div. xiyuan 2016/07/25 18:03:40 Probably due to polymer's "layout horizontal" tryi Show quoted text On 2016/07/25 15:36:05, khmel wrote: > I found weird behavior when size of checkbox depends on number of lines in text > description. This makes checkbox with declared 16px in css file appeared as 12px > checkbox for 2 lines and 8px for 3 lines text description > (https://drive.google.com/a/google.com/file/d/0B63tZNwdjs-qejg3dEMwek9TLVk/vie...). > It was also not possible to apply padding because it was ignored. I found > workaround by wrapping checkbox by div. Probably due to polymer's "layout horizontal" trying to something smart. khmel 2016/07/25 22:48:48 Yes, did some experiments and can confirm that pro Show quoted text On 2016/07/25 18:03:40, xiyuan wrote: > On 2016/07/25 15:36:05, khmel wrote: > > I found weird behavior when size of checkbox depends on number of lines in > text > > description. This makes checkbox with declared 16px in css file appeared as > 12px > > checkbox for 2 lines and 8px for 3 lines text description > > > (https://drive.google.com/a/google.com/file/d/0B63tZNwdjs-qejg3dEMwek9TLVk/vie...). > > It was also not possible to apply padding because it was ignored. I found > > workaround by wrapping checkbox by div. > > Probably due to polymer's "layout horizontal" trying to something smart. Yes, did some experiments and can confirm that problem because of flex layout. Once I set flex layout checkbox is affected. I googled and found similar problem here (webkit bug?): http://stackoverflow.com/questions/34220553/flexbox-resizes-a-checkbox-too-small I tried to use different workaround and it seems current approach with wrapping <input> is more convenient.
67 hidden>	67 <input type="checkbox" class="checkbox-option" id="enable-metrics"

	68 hidden>

	69 </div>

68 <p class="checkbox-text" id="text-metrics"></p>	70 <p class="checkbox-text" id="text-metrics"></p>
	xiyuan 2016/07/25 18:03:40 While you are changing this file, can we change th While you are changing this file, can we change this to a label and associated with corresponding checkbox. Otherwise, user has to click on the checkbox to toggle it, kind of hard to aim. i.e. replace this <p> with <label class="checkbox-text" id="text-metrics" for="enable-metrics"></label> or wrap the <input> and <p> with <label> khmel 2016/07/25 22:48:48 presubmit is not happy with with 'for'. So wrappin Show quoted text On 2016/07/25 18:03:40, xiyuan wrote: > While you are changing this file, can we change this to a label and associated > with corresponding checkbox. Otherwise, user has to click on the checkbox to > toggle it, kind of hard to aim. > > i.e. replace this <p> with > <label class="checkbox-text" id="text-metrics" for="enable-metrics"></label> > > or wrap the <input> and <p> with <label> presubmit is not happy with with 'for'. So wrapping whole block. That is more user friendly indeed. Thanks for idea!
69 </div>	71 </div>

70 <div id="section-backup-restore" class="layout horizontal	72 <div class="layout horizontal section-checkbox-container">

71 section-checkbox-container">	73 <div class="checkbox-container">

72 <input type="checkbox" class="checkbox-option"	74 <input type="checkbox" class="checkbox-option"

73 id="enable-backup-restore">	75 id="enable-backup-restore">

	76 </div>

74 <p class="checkbox-text" id="text-backup-restore"></p>	77 <p class="checkbox-text" id="text-backup-restore"></p>

75 </div>	78 </div>

	79 <div class="layout horizontal section-checkbox-container">

	80 <div class="checkbox-container">

	81 <input type="checkbox" class="checkbox-option"

	82 id="enable-location-service">

	83 </div>

	84 <p class="checkbox-text" id="text-location-service"></p>

	85 </div>

76 <div class="layout horizontal end-justified section-buttons">	86 <div class="layout horizontal end-justified section-buttons">

77 <paper-button class="white" id="button-cancel"	87 <paper-button class="white" id="button-cancel"

78 i18n-content="buttonCancel">	88 i18n-content="buttonCancel">

79 </paper-button>	89 </paper-button>

80 <div class="button-separator"></div>	90 <div class="button-separator"></div>

81 <paper-button class="blue" id="button-agree"	91 <paper-button class="blue" id="button-agree"

82 i18n-content="buttonAgree">	92 i18n-content="buttonAgree">

83 </paper-button>	93 </paper-button>

84 </div>	94 </div>

85 </div>	95 </div>

(...skipping 30 matching lines...) Expand all Loading...
116 <paper-button class="blue" id="button-send-feedback"	126 <paper-button class="blue" id="button-send-feedback"

117 i18n-content="buttonSendFeedback">	127 i18n-content="buttonSendFeedback">

118 </paper-button>	128 </paper-button>

119 <paper-button class="blue" id="button-retry" i18n-content="buttonRetry">	129 <paper-button class="blue" id="button-retry" i18n-content="buttonRetry">

120 </paper-button>	130 </paper-button>

121 </div>	131 </div>

122 </div>	132 </div>

123 </div>	133 </div>

124 </body>	134 </body>

125 </html>	135 </html>

OLD	NEW