Reduce copying in sending service responses.

Reduce copying in sending service responses.

Add missing safepoint transitions.

Issue #27092
Likely contributes to Issue #27010

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with endless recorder)
Before 215M -> 321M
After 182M -> 233M

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/d418dde65bc6c25840d2d6b0890d4ce4ae3ec0ef

[rmacnak, 2016-08-17 23:47:39]

Description was changed from

==========
.


.


.

BUG=
==========

to

==========
Reduce copying in sending service responses.

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

[rmacnak, 2016-08-18 00:38:23]

Description was changed from

==========
Reduce copying in sending service responses.

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

to

==========
Reduce copying in sending service responses.

Add missing safepoint transitions.

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

[rmacnak, 2016-08-18 00:47:11]

Description was changed from

==========
Reduce copying in sending service responses.

Add missing safepoint transitions.

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

to

==========
Reduce copying in sending service responses.

Add missing safepoint transitions.

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

[rmacnak, 2016-08-18 01:11:20]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-08-18 14:23:31]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[Cutch, 2016-08-18 14:23:31]

LGTM

+asiva for the wine bottle accounting.

[siva, 2016-08-18 16:33:17]

Very cool.

Some DBC

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/s...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/s...
runtime/bin/vmservice/server.dart:57: socket.add(result);  // Binary message.
why is this not :

if ((result is String) || (result is Uint8List)) {
  ...
} else {
}

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/v...
File runtime/bin/vmservice/vmservice_io.dart (right):

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/v...
runtime/bin/vmservice/vmservice_io.dart:12: import 'dart:typed_data';
There seems to be no change in this file other than this import, why was this
needed?

[rmacnak, 2016-08-18 17:00:39]

Description was changed from

==========
Reduce copying in sending service responses.

Add missing safepoint transitions.

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

to

==========
Reduce copying in sending service responses.

Add missing safepoint transitions.

Issue #27092
Likely contributes to Issue #27010

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

[rmacnak, 2016-08-18 17:30:59]

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/s...
File runtime/bin/vmservice/server.dart (right):

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/s...
runtime/bin/vmservice/server.dart:57: socket.add(result);  // Binary message.
On 2016/08/18 16:33:17, siva wrote:
> why is this not :
> 
> if ((result is String) || (result is Uint8List)) {
>   ...
> } else {
> }

Done.

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/v...
File runtime/bin/vmservice/vmservice_io.dart (right):

https://codereview.chromium.org/2254543006/diff/20001/runtime/bin/vmservice/v...
runtime/bin/vmservice/vmservice_io.dart:12: import 'dart:typed_data';
On 2016/08/18 16:33:17, siva wrote:
> There seems to be no change in this file other than this import, why was this
> needed?

For 'is UInt8List'

[rmacnak, 2016-08-18 17:34:55]

Description was changed from

==========
Reduce copying in sending service responses.

Add missing safepoint transitions.

Issue #27092
Likely contributes to Issue #27010

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M
==========

to

==========
Reduce copying in sending service responses.

Add missing safepoint transitions.

Issue #27092
Likely contributes to Issue #27010

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with
endless recorder)
Before 215M -> 321M
After 182M -> 233M

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d418dde65bc6c25840d2d6b0890d4ce4ae3ec0ef
==========

[rmacnak, 2016-08-18 17:34:56]

Committed patchset #3 (id:40001) manually as
d418dde65bc6c25840d2d6b0890d4ce4ae3ec0ef (presubmit successful).