runtime/vm/timeline.cc - Issue 2254543006: Reduce copying in sending service responses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/timeline.cc

Issue 2254543006: Reduce copying in sending service responses. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: dbc, sync Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/timeline.cc

diff --git a/runtime/vm/timeline.cc b/runtime/vm/timeline.cc

index f4c62a84991d78e01de164447c5d1a4167fec41c..7e9ba2d179c9ec86ad6615ce49555b26a69e4eb9 100644

--- a/runtime/vm/timeline.cc

+++ b/runtime/vm/timeline.cc

@@ -1180,7 +1180,7 @@ void TimelineEventRecorder::WriteTo(const char* directory) {

// Steal output from JSONStream.

char* output = NULL;

intptr_t output_length = 0;

- js.Steal(const_cast<const char**>(&output), &output_length);

+ js.Steal(&output, &output_length);

(*file_write)(output, output_length, file);

// Free the stolen output.

free(output);

« no previous file with comments | « runtime/vm/service_test.cc ('k') | sdk/lib/vmservice/vmservice.dart » ('j') | no next file with comments »