Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: components/offline_pages/offline_page_feature.cc

Issue 2254343002: Add new feature flag to enable background loader for downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_feature.cc
diff --git a/components/offline_pages/offline_page_feature.cc b/components/offline_pages/offline_page_feature.cc
index 0d161d6158e216aa6f9108e573864e0f30f77dac..36d14f0384674fc23bd8ae8fc1cdd8a24758a0b0 100644
--- a/components/offline_pages/offline_page_feature.cc
+++ b/components/offline_pages/offline_page_feature.cc
@@ -29,10 +29,14 @@ const base::Feature kOfflinePagesCTFeature {
const base::Feature kOfflinePagesSharingFeature{
"OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kBackgroundLoadingForDownloadsFeature{
+ "BackgroundLoadingForDownloads", base::FEATURE_ENABLED_BY_DEFAULT};
+
bool IsOfflinePagesEnabled() {
return IsOfflineBookmarksEnabled() || IsOffliningRecentPagesEnabled() ||
IsOfflinePagesBackgroundLoadingEnabled() ||
- IsOfflinePagesCTEnabled() || IsOfflinePagesSharingEnabled();
+ IsOfflinePagesCTEnabled() || IsOfflinePagesSharingEnabled() ||
+ IsBackgroundLoadingForDownloadsEnabled();
Ted C 2016/08/19 16:23:26 ../../components/offline_pages/offline_page_featur
chili 2016/08/19 20:20:02 Oops. Thanks for the catch!
}
bool IsOfflineBookmarksEnabled() {
@@ -55,4 +59,8 @@ bool IsOfflinePagesSharingEnabled() {
return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature);
}
+bool IsBackgroundLoadingForDownloadsEnabled() {
+ return base::FeatureList::IsEnabled(kBackgroundLoadingForDownloadsFeature);
+}
+
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698