Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: components/offline_pages/offline_page_feature.cc

Issue 2254343002: Add new feature flag to enable background loader for downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_feature.h" 5 #include "components/offline_pages/offline_page_feature.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/feature_list.h" 9 #include "base/feature_list.h"
10 10
(...skipping 11 matching lines...) Expand all
22 "OfflinePagesBackgroundLoading", base::FEATURE_DISABLED_BY_DEFAULT 22 "OfflinePagesBackgroundLoading", base::FEATURE_DISABLED_BY_DEFAULT
23 }; 23 };
24 24
25 const base::Feature kOfflinePagesCTFeature { 25 const base::Feature kOfflinePagesCTFeature {
26 "OfflinePagesCT", base::FEATURE_DISABLED_BY_DEFAULT 26 "OfflinePagesCT", base::FEATURE_DISABLED_BY_DEFAULT
27 }; 27 };
28 28
29 const base::Feature kOfflinePagesSharingFeature{ 29 const base::Feature kOfflinePagesSharingFeature{
30 "OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT}; 30 "OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT};
31 31
32 const base::Feature kBackgroundLoadingForDownloadsFeature{
33 "BackgroundLoadingForDownloads", base::FEATURE_ENABLED_BY_DEFAULT};
34
32 bool IsOfflinePagesEnabled() { 35 bool IsOfflinePagesEnabled() {
33 return IsOfflineBookmarksEnabled() || IsOffliningRecentPagesEnabled() || 36 return IsOfflineBookmarksEnabled() || IsOffliningRecentPagesEnabled() ||
34 IsOfflinePagesBackgroundLoadingEnabled() || 37 IsOfflinePagesBackgroundLoadingEnabled() ||
35 IsOfflinePagesCTEnabled() || IsOfflinePagesSharingEnabled(); 38 IsOfflinePagesCTEnabled() || IsOfflinePagesSharingEnabled() ||
39 IsBackgroundLoadingForDownloadsEnabled();
Ted C 2016/08/19 16:23:26 ../../components/offline_pages/offline_page_featur
chili 2016/08/19 20:20:02 Oops. Thanks for the catch!
36 } 40 }
37 41
38 bool IsOfflineBookmarksEnabled() { 42 bool IsOfflineBookmarksEnabled() {
39 return base::FeatureList::IsEnabled(kOfflineBookmarksFeature); 43 return base::FeatureList::IsEnabled(kOfflineBookmarksFeature);
40 } 44 }
41 45
42 bool IsOffliningRecentPagesEnabled() { 46 bool IsOffliningRecentPagesEnabled() {
43 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature); 47 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature);
44 } 48 }
45 49
46 bool IsOfflinePagesBackgroundLoadingEnabled() { 50 bool IsOfflinePagesBackgroundLoadingEnabled() {
47 return base::FeatureList::IsEnabled(kOfflinePagesBackgroundLoadingFeature); 51 return base::FeatureList::IsEnabled(kOfflinePagesBackgroundLoadingFeature);
48 } 52 }
49 53
50 bool IsOfflinePagesCTEnabled() { 54 bool IsOfflinePagesCTEnabled() {
51 return base::FeatureList::IsEnabled(kOfflinePagesCTFeature); 55 return base::FeatureList::IsEnabled(kOfflinePagesCTFeature);
52 } 56 }
53 57
54 bool IsOfflinePagesSharingEnabled() { 58 bool IsOfflinePagesSharingEnabled() {
55 return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature); 59 return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature);
56 } 60 }
57 61
62 bool IsBackgroundLoadingForDownloadsEnabled() {
63 return base::FeatureList::IsEnabled(kBackgroundLoadingForDownloadsFeature);
64 }
65
58 } // namespace offline_pages 66 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698