Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2254303004: Worker: Stop WorkerLoaderProxy::postTaskToWorkerGlobalScope from returning bool (Closed)

Created:
4 years, 4 months ago by nhiroki
Modified:
4 years, 4 months ago
Reviewers:
haraken, yhirano
CC:
chromium-reviews, kinuko+worker_chromium.org, tyoshino+watch_chromium.org, falken, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, Nate Chapin, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Stop WorkerLoaderProxy::postTaskToWorkerGlobalScope from returning bool No one takes care of the return value. BUG=639153 Committed: https://crrev.com/4c022860cc2564271b19289696b4e675e73cc4bc Cr-Commit-Position: refs/heads/master@{#413665}

Patch Set 1 #

Messages

Total messages: 19 (12 generated)
nhiroki
PTAL, thanks!
4 years, 4 months ago (2016-08-19 08:56:57 UTC) #5
yhirano
lgtm
4 years, 4 months ago (2016-08-23 02:11:13 UTC) #8
nhiroki
+haraken@, Ptal as an owner of Sources/{core,web}. Thanks.
4 years, 4 months ago (2016-08-23 02:14:28 UTC) #12
haraken
LGTM
4 years, 4 months ago (2016-08-23 02:20:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254303004/1
4 years, 4 months ago (2016-08-23 03:16:22 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 04:43:47 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 04:45:17 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c022860cc2564271b19289696b4e675e73cc4bc
Cr-Commit-Position: refs/heads/master@{#413665}

Powered by Google App Engine
This is Rietveld 408576698