third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h - Issue 2254303004: Worker: Stop WorkerLoaderProxy::postTaskToWorkerGlobalScope from returning bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h

Issue 2254303004: Worker: Stop WorkerLoaderProxy::postTaskToWorkerGlobalScope from returning bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h

index 87064e259ea923b6629a62e88e96216533e91440..aa922e7e79cf4036e9e834584eb57630663a40d9 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h

@@ -99,7 +99,7 @@ private:

// These methods are called on different threads to schedule loading

// requests and to send callbacks back to WorkerGlobalScope.

void postTaskToLoader(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>) override;

- bool postTaskToWorkerGlobalScope(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>) override;

+ void postTaskToWorkerGlobalScope(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>) override;

// Returns true if this is called on the parent context thread.

bool isParentContextThread() const;