Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2254303003: Revert of Mark several color-profile-* layout tests as flaky. (Closed)

Created:
4 years, 4 months ago by rjwright
Modified:
4 years, 4 months ago
Reviewers:
Guido Urdaneta, ericrk
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark several color-profile-* layout tests as flaky. (patchset #1 id:1 of https://codereview.chromium.org/2242173007/ ) Reason for revert: This syntax seems to have prevented rebaseline-o-matic from rebaselining these tests https://codereview.chromium.org/2254133003/ Let's allow them to be rebaselined, and re-mark as flaky if they still fail. Original issue's description: > Mark several color-profile-* layout tests as flaky. > > The failure seems to occurs on Win10 only, but these tests already had entries and it was not possible to add a new Win10-specific entry. > > TBR=ericrk@chromium.org > BUG=638843 > > Committed: https://crrev.com/1977238868c1fc98f16589afec06ea7f031f3333 > Cr-Commit-Position: refs/heads/master@{#412776} TBR=ericrk@chromium.org,guidou@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rjwright
Created Revert of Mark several color-profile-* layout tests as flaky.
4 years, 4 months ago (2016-08-19 00:58:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254303003/1
4 years, 4 months ago (2016-08-19 00:59:14 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 00:59:53 UTC) #5
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1322
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with
conflicts.
  U third_party/WebKit/LayoutTests/TestExpectations

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
0bf913ff815fa625b05dfc3f6d2856af71552726..d9b4481cb441a9f292dd914e5fda1a2ac3e32da5
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1322,13 +1322,12 @@
 # This test fails with the stable release mode.
 crbug.com/490015
virtual/stable/http/tests/navigation/same-and-different-back.html [ Skip ]
 
-# See also crbug.com/638843 for failures of the color-profile* tests
-crbug.com/632274 virtual/gpu-rasterization/fast/images/color-profile-layer.html
[ NeedsRebaseline Pass Failure ]
-crbug.com/632274
virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html [
NeedsRebaseline Pass Failure ]
-crbug.com/632274 virtual/gpu-rasterization/fast/images/color-profile-group.html
[ NeedsRebaseline Pass Failure ]
+crbug.com/632274 virtual/gpu-rasterization/fast/images/color-profile-layer.html
[ NeedsRebaseline ]
+crbug.com/632274
virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text.html [
NeedsRebaseline ]
+crbug.com/632274 virtual/gpu-rasterization/fast/images/color-profile-group.html
[ NeedsRebaseline ]
 crbug.com/632274 virtual/gpu-rasterization/fast/images/182.html [
NeedsRebaseline ]
 crbug.com/632274 virtual/gpu-rasterization/fast/images/23-55.html [
NeedsRebaseline ]
-crbug.com/632274
virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html [
NeedsRebaseline Pass Failure ]
+crbug.com/632274
virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern.html [
NeedsRebaseline ]
 crbug.com/632274 virtual/gpu-rasterization/fast/images/55.html [
NeedsRebaseline ]
 crbug.com/632274 virtual/gpu-rasterization/fast/images/12-55.html [
NeedsRebaseline ]
 crbug.com/632274 virtual/gpu-rasterization/fast/images/2-dht.html [
NeedsRebaseline ]

Powered by Google App Engine
This is Rietveld 408576698