Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2254133002: Reland of "Adds a WebRTC browser_test with opus dtx enabled.". (Closed)

Created:
4 years, 4 months ago by Henrik Grunell
Modified:
4 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, posciak+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, tnakamura+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Adds a WebRTC browser_test with opus dtx enabled.". Original CL: https://codereview.chromium.org/2190533002/ Original commit: e9df939bf67e2dea8e3ca1d9a0857272324611b8 Revert CL: https://codereview.chromium.org/2195293002/ Revert commit: 0dc179b22f88b81c6a083670bb09f22108420a4e The crash in the WebRTC audio quality browser tests was caused by one misplaced line in the javascript code. BUG=631927 TBR=phoglund@chromium.org,jochen@chromium.org,minyue@chromium.org patch from issue 2248093002 at patchset 20001 (http://crrev.com/2248093002#ps20001) Committed: https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849 Cr-Commit-Position: refs/heads/master@{#412826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -68 lines) Patch
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.h View 2 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 5 chunks +23 lines, -28 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_perf.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_perf_browsertest.cc View 6 chunks +38 lines, -8 lines 0 comments Download
M chrome/browser/media/webrtc_video_quality_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/webrtc/munge_sdp.js View 2 chunks +44 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection.js View 5 chunks +55 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Henrik Grunell
I'm landning this reland for Ivo. Original reland CL in https://codereview.chromium.org/2248093002/#ps20001 where the fix can ...
4 years, 4 months ago (2016-08-18 09:03:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254133002/1
4 years, 4 months ago (2016-08-18 09:04:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/54151)
4 years, 4 months ago (2016-08-18 09:05:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254133002/1
4 years, 4 months ago (2016-08-18 14:08:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 14:55:34 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 14:58:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849
Cr-Commit-Position: refs/heads/master@{#412826}

Powered by Google App Engine
This is Rietveld 408576698