Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Side by Side Diff: chrome/browser/media/webrtc_video_quality_browsertest.cc

Issue 2254133002: Reland of "Adds a WebRTC browser_test with opus dtx enabled.". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/media/webrtc_perf_browsertest.cc ('k') | chrome/test/data/webrtc/munge_sdp.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/environment.h" 9 #include "base/environment.h"
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 embedded_test_server()->GetURL(kMainWebrtcTestHtmlPage), 271 embedded_test_server()->GetURL(kMainWebrtcTestHtmlPage),
272 test_config_.constraints); 272 test_config_.constraints);
273 content::WebContents* right_tab = 273 content::WebContents* right_tab =
274 OpenPageAndGetUserMediaInNewTabWithConstraints( 274 OpenPageAndGetUserMediaInNewTabWithConstraints(
275 embedded_test_server()->GetURL(kCapturingWebrtcHtmlPage), 275 embedded_test_server()->GetURL(kCapturingWebrtcHtmlPage),
276 test_config_.constraints); 276 test_config_.constraints);
277 277
278 SetupPeerconnectionWithLocalStream(left_tab); 278 SetupPeerconnectionWithLocalStream(left_tab);
279 SetupPeerconnectionWithLocalStream(right_tab); 279 SetupPeerconnectionWithLocalStream(right_tab);
280 280
281 NegotiateCall(left_tab, right_tab, video_codec); 281 if (!video_codec.empty()) {
282 SetDefaultVideoCodec(left_tab, video_codec);
283 SetDefaultVideoCodec(right_tab, video_codec);
284 }
285 NegotiateCall(left_tab, right_tab);
282 286
283 // Poll slower here to avoid flooding the log with messages: capturing and 287 // Poll slower here to avoid flooding the log with messages: capturing and
284 // sending frames take quite a bit of time. 288 // sending frames take quite a bit of time.
285 int polling_interval_msec = 1000; 289 int polling_interval_msec = 1000;
286 290
287 EXPECT_TRUE(test::PollingWaitUntil("doneFrameCapturing()", "done-capturing", 291 EXPECT_TRUE(test::PollingWaitUntil("doneFrameCapturing()", "done-capturing",
288 right_tab, polling_interval_msec)); 292 right_tab, polling_interval_msec));
289 293
290 HangUp(left_tab); 294 HangUp(left_tab);
291 295
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) { 361 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
358 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. " 362 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. "
359 "Skipping WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 " 363 "Skipping WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 "
360 "(test \"OK\")"; 364 "(test \"OK\")";
361 return; 365 return;
362 } 366 }
363 TestVideoQuality("H264"); 367 TestVideoQuality("H264");
364 } 368 }
365 369
366 #endif // BUILDFLAG(RTC_USE_H264) 370 #endif // BUILDFLAG(RTC_USE_H264)
OLDNEW
« no previous file with comments | « chrome/browser/media/webrtc_perf_browsertest.cc ('k') | chrome/test/data/webrtc/munge_sdp.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698