Fix leaked array buffer allocators of isolates

Fix leaked array buffer allocators of isolates

The array buffer allocators are allocated and owned by pdfium code,
they should be deleted properly after the corresponding isolates are
disposed.

BUG=pdfium:242
Committed: https://pdfium.googlesource.com/pdfium/+/ad589d7b83768f3b78ae6b9c90aa418611cc12c2

[Wei Li, 2016-08-19 00:42:53]

Description was changed from

==========
Fix leaked isolates' allocators

The array buffer allocators are allocated and owned by pdfium code,
they should be deleted properly after the corresponding isolate is
disposed.

BUG=pdfium:242
==========

to

==========
Fix leaked array buffer allocators of isolates

The array buffer allocators are allocated and owned by pdfium code,
they should be deleted properly after the corresponding isolates are
disposed.

BUG=pdfium:242
==========

[Wei Li, 2016-08-19 00:43:16]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 00:43:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 00:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 00:59:28]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-19 05:06:08]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-08-19 16:49:48]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-19 16:49:49]

pls review, thanks

[Lei Zhang, 2016-08-19 18:28:22]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2016-08-19 18:28:22]

+tsepez

[Lei Zhang, 2016-08-19 18:28:58]

https://codereview.chromium.org/2254123004/diff/1/fxjs/cfxjse_isolatetracker.cpp
File fxjs/cfxjse_isolatetracker.cpp (right):

https://codereview.chromium.org/2254123004/diff/1/fxjs/cfxjse_isolatetracker....
fxjs/cfxjse_isolatetracker.cpp:31: auto ret = m_AllocatorMap.find(pIsolate);
Just: m_AllocatorMap.erase(pIsolate);

[Tom Sepez, 2016-08-19 18:31:17]

LGTM apart from thestig's comment.

[Wei Li, 2016-08-19 19:47:19]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 19:47:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 19:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:59:38]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-19 21:09:10]

thanks

https://codereview.chromium.org/2254123004/diff/1/fxjs/cfxjse_isolatetracker.cpp
File fxjs/cfxjse_isolatetracker.cpp (right):

https://codereview.chromium.org/2254123004/diff/1/fxjs/cfxjse_isolatetracker....
fxjs/cfxjse_isolatetracker.cpp:31: auto ret = m_AllocatorMap.find(pIsolate);
On 2016/08/19 18:28:58, Lei Zhang wrote:
> Just: m_AllocatorMap.erase(pIsolate);

Done.

[Wei Li, 2016-08-19 21:09:17]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-08-19 21:09:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2254123004/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-08-19 21:09:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 21:09:36]

Description was changed from

==========
Fix leaked array buffer allocators of isolates

The array buffer allocators are allocated and owned by pdfium code,
they should be deleted properly after the corresponding isolates are
disposed.

BUG=pdfium:242
==========

to

==========
Fix leaked array buffer allocators of isolates

The array buffer allocators are allocated and owned by pdfium code,
they should be deleted properly after the corresponding isolates are
disposed.

BUG=pdfium:242

Committed:
https://pdfium.googlesource.com/pdfium/+/ad589d7b83768f3b78ae6b9c90aa418611cc...
==========

[commit-bot: I haz the power, 2016-08-19 21:09:37]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/ad589d7b83768f3b78ae6b9c90aa418611cc...