Fix leaked array buffer allocators of isolates

fxjs/cfxjse_isolatetracker.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fxjs/cfxjse_isolatetracker.h"
 
 #include <algorithm>
 
 CFXJSE_IsolateTracker::CFXJSE_IsolateTracker() {}
 
 CFXJSE_IsolateTracker::~CFXJSE_IsolateTracker() {}
 
-void CFXJSE_IsolateTracker::Append(v8::Isolate* pIsolate) {
+void CFXJSE_IsolateTracker::Append(
+    v8::Isolate* pIsolate,
+    std::unique_ptr<v8::ArrayBuffer::Allocator> alloc) {
   m_OwnedIsolates.push_back(pIsolate);
+  m_AllocatorMap[pIsolate] = std::move(alloc);
 }
 
 void CFXJSE_IsolateTracker::Remove(
     v8::Isolate* pIsolate,
     CFXJSE_IsolateTracker::DisposeCallback lpfnDisposeCallback) {
   auto it = std::find(m_OwnedIsolates.begin(), m_OwnedIsolates.end(), pIsolate);
   bool bFound = it != m_OwnedIsolates.end();
   if (bFound)
     m_OwnedIsolates.erase(it);
   lpfnDisposeCallback(pIsolate, bFound);
+
+  auto ret = m_AllocatorMap.find(pIsolate);

[Lei Zhang, 2016/08/19 18:28:58]

Just: m_AllocatorMap.erase(pIsolate);

[Wei Li, 2016/08/19 21:09:10]

Done.

+  if (ret != m_AllocatorMap.end())
+    m_AllocatorMap.erase(ret);
 }
 
 void CFXJSE_IsolateTracker::RemoveAll(
     CFXJSE_IsolateTracker::DisposeCallback lpfnDisposeCallback) {
   for (v8::Isolate* pIsolate : m_OwnedIsolates)
     lpfnDisposeCallback(pIsolate, true);
 
   m_OwnedIsolates.clear();
+  m_AllocatorMap.clear();
 }