MD Settings: reduce complexity and overhead of prefs singleton

MD Settings: reduce complexity and overhead of prefs singleton

Remove <settings-prefs-singleton> and put all the logic in <settings-prefs>.
No more custom listeners or fragile test structures.

This depends on removing <settings-languages-singleton>.

BUG=638802
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/190a0525f1b960e8f241819421cc94c0f0e0f38a
Cr-Commit-Position: refs/heads/master@{#413062}

[michaelpg, 2016-08-18 04:08:00]

Description was changed from

==========
MD Settings: reduce complexity and overhead of prefs singleton

Remove <settings-prefs-singleton> and put all the logic in <settings-prefs>.
No more custom listeners or fragile test structures.

This depends on removing <settings-languages-singleton>.

BUG=638802
R=dbeam@chromium.org
==========

to

==========
MD Settings: reduce complexity and overhead of prefs singleton

Remove <settings-prefs-singleton> and put all the logic in <settings-prefs>.
No more custom listeners or fragile test structures.

This depends on removing <settings-languages-singleton>.

BUG=638802
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-18 04:22:05]

This is the thing groby@ mentioned seeing weird events for. Figured it was
easier to delete 150 lines than try to debug them.

https://codereview.chromium.org/2254113002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/languages_tests.js (right):

https://codereview.chromium.org/2254113002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/languages_tests.js:122: assertEquals('en-US',
languageHelper.languages.enabled[0].language.code);
the old code was assuming changes from previous test()s persisted, blegh. now
each test starts with a fresh instance of everything.

[Dan Beam, 2016-08-18 05:00:13]

lgtm

https://codereview.chromium.org/2254113002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/prefs/prefs.js (right):

https://codereview.chromium.org/2254113002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs.js:183: if (e.path == 'prefs')
nit: maybe combine with above?

[michaelpg, 2016-08-19 04:52:15]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-19 04:52:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2254113002/#ps60001
(title: "Nit")

[commit-bot: I haz the power, 2016-08-19 04:52:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 06:04:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-19 06:08:05]

Description was changed from

==========
MD Settings: reduce complexity and overhead of prefs singleton

Remove <settings-prefs-singleton> and put all the logic in <settings-prefs>.
No more custom listeners or fragile test structures.

This depends on removing <settings-languages-singleton>.

BUG=638802
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: reduce complexity and overhead of prefs singleton

Remove <settings-prefs-singleton> and put all the logic in <settings-prefs>.
No more custom listeners or fragile test structures.

This depends on removing <settings-languages-singleton>.

BUG=638802
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/190a0525f1b960e8f241819421cc94c0f0e0f38a
Cr-Commit-Position: refs/heads/master@{#413062}
==========

[commit-bot: I haz the power, 2016-08-19 06:08:06]

Patchset 4 (id:??) landed as
https://crrev.com/190a0525f1b960e8f241819421cc94c0f0e0f38a
Cr-Commit-Position: refs/heads/master@{#413062}

[michaelpg, 2016-08-19 17:25:24]

(landed, just sending draft)

https://codereview.chromium.org/2254113002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/prefs/prefs.js (right):

https://codereview.chromium.org/2254113002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs.js:183: if (e.path == 'prefs')
On 2016/08/18 05:00:12, Dan Beam wrote:
> nit: maybe combine with above?

Done.