chrome/test/data/webui/settings/passwords_and_forms_browsertest.js - Issue 2254113002: MD Settings: reduce complexity and overhead of prefs singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/passwords_and_forms_browsertest.js

Issue 2254113002: MD Settings: reduce complexity and overhead of prefs singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SimplifyLanguages

Patch Set: Nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/webui/settings/passwords_and_forms_browsertest.js

diff --git a/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js b/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js

index 56600d11343a76ed256338fd9a4bf4f415ac4636..f8e224b98d58bca57e2b8cd2e7a555983f05610f 100644

--- a/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js

+++ b/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js

@@ -269,8 +269,7 @@ PasswordsAndFormsBrowserTest.prototype = {

return new Promise(function(resolve) {

CrSettingsPrefs.deferInitialization = true;

var prefs = document.createElement('settings-prefs');

- document.body.appendChild(prefs);

- prefs.initializeForTesting(new settings.FakeSettingsPrivate([

+ prefs.initialize(new settings.FakeSettingsPrivate([

{

key: 'autofill.enabled',

type: chrome.settingsPrivate.PrefType.BOOLEAN,

« no previous file with comments | « chrome/test/data/webui/settings/languages_tests.js ('k') | chrome/test/data/webui/settings/prefs_tests.js » ('j') | no next file with comments »