Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2254103004: Don't emit dead code in circle shader when not using distance vectors. (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't emit dead code in circle shader when not using distance vectors. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254103004 Committed: https://skia.googlesource.com/skia/+/adf4edc4d6ddf781b2910f457ba360d99072604a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
bsalomon
4 years, 4 months ago (2016-08-18 13:59:57 UTC) #3
robertphillips
lgtm
4 years, 4 months ago (2016-08-18 14:47:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254103004/1
4 years, 4 months ago (2016-08-18 15:31:34 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 15:32:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/adf4edc4d6ddf781b2910f457ba360d99072604a

Powered by Google App Engine
This is Rietveld 408576698