Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2254063003: Reland of Android: Make the spare renderer accessible to all Chrome tabs. (Closed)

Created:
4 years, 4 months ago by Benoit L
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: Make the spare renderer accessible to all Chrome tabs. Original CL description (from https://codereview.chromium.org/2199393002/): Android: Make the spare renderer accessible to all Chrome tabs. In Custom Tabs, an external application can "warm up" Chrome. This creates and initializes a spare renderer, and has been found to be a significant optimization for loading performance. This patch moves the spare renderer logic out of Custom Tabs, and makes it accessible and useful for regular navigations in Chrome. Note that this patch doesn't add new call sites for the spare renderer creation. TBR=yusufo,maria # trivial fix to a test. BUG=633964 Committed: https://crrev.com/21f7b3ae303e08aaccd054870bf5b3978589d702 Cr-Commit-Position: refs/heads/master@{#412808}

Patch Set 1 #

Patch Set 2 : Explicitely destroy the observer. #

Patch Set 3 : Pass the WebContents to the observer (for proper destruction). #

Messages

Total messages: 12 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254063003/40001
4 years, 4 months ago (2016-08-18 12:19:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-18 13:17:32 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 13:20:34 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/21f7b3ae303e08aaccd054870bf5b3978589d702
Cr-Commit-Position: refs/heads/master@{#412808}

Powered by Google App Engine
This is Rietveld 408576698