chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2254063003: Reland of Android: Make the spare renderer accessible to all Chrome tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2254063003: Reland of Android: Make the spare renderer accessible to all Chrome tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass the WebContents to the observer (for proper destruction). Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index c3146097d72895c0cba7bb8d384709fae5badbee..67ab9665c33911904c7d300ebed15a2e775afcfe 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -52,6 +52,7 @@ import org.chromium.chrome.browser.SwipeRefreshHandler;

import org.chromium.chrome.browser.TabState;

import org.chromium.chrome.browser.TabState.WebContentsState;

import org.chromium.chrome.browser.UrlConstants;

+import org.chromium.chrome.browser.WarmupManager;

import org.chromium.chrome.browser.WebContentsFactory;

import org.chromium.chrome.browser.banners.AppBannerManager;

import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;

@@ -1461,7 +1462,12 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

boolean creatingWebContents = webContents == null;

if (creatingWebContents) {

- webContents = WebContentsFactory.createWebContents(isIncognito(), initiallyHidden);

+ webContents = WarmupManager.getInstance().takeSpareWebContents(

+ isIncognito(), initiallyHidden);

+ if (webContents == null) {

+ webContents =

+ WebContentsFactory.createWebContents(isIncognito(), initiallyHidden);

+ }

}

ContentViewCore contentViewCore = ContentViewCore.fromWebContents(webContents);