Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: content/browser/service_worker/service_worker_context_unittest.cc

Issue 225403014: ServiceWorker: propagate provider_id to the browser process in .register + int32/int cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_unittest.cc
diff --git a/content/browser/service_worker/service_worker_context_unittest.cc b/content/browser/service_worker/service_worker_context_unittest.cc
index 237ed4e89a109c249cbd61754d5e9cdb85197aeb..24b2ed3b6e10c79c6061be4a440ce643b0c9bc0c 100644
--- a/content/browser/service_worker/service_worker_context_unittest.cc
+++ b/content/browser/service_worker/service_worker_context_unittest.cc
@@ -116,6 +116,7 @@ TEST_F(ServiceWorkerContextTest, Register) {
GURL("http://www.example.com/*"),
GURL("http://www.example.com/service_worker.js"),
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &registration_id, &version_id));
ASSERT_FALSE(called);
@@ -168,6 +169,7 @@ TEST_F(ServiceWorkerContextTest, Register_RejectInstall) {
GURL("http://www.example.com/*"),
GURL("http://www.example.com/service_worker.js"),
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &registration_id, &version_id));
ASSERT_FALSE(called);
@@ -202,6 +204,7 @@ TEST_F(ServiceWorkerContextTest, Register_DuplicateScriptNoActiveWorker) {
GURL("http://www.example.com/*"),
GURL("http://www.example.com/service_worker.js"),
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &old_registration_id, &old_version_id));
ASSERT_FALSE(called);
@@ -219,6 +222,7 @@ TEST_F(ServiceWorkerContextTest, Register_DuplicateScriptNoActiveWorker) {
GURL("http://www.example.com/*"),
GURL("http://www.example.com/service_worker.js"),
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &new_registration_id, &new_version_id));
ASSERT_FALSE(called);
@@ -242,6 +246,7 @@ TEST_F(ServiceWorkerContextTest, Unregister) {
pattern,
GURL("http://www.example.com/service_worker.js"),
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &registration_id, &version_id));
ASSERT_FALSE(called);
@@ -252,7 +257,7 @@ TEST_F(ServiceWorkerContextTest, Unregister) {
called = false;
context_->UnregisterServiceWorker(
- pattern, render_process_id_, MakeUnregisteredCallback(&called));
+ pattern, render_process_id_, NULL, MakeUnregisteredCallback(&called));
ASSERT_FALSE(called);
base::RunLoop().RunUntilIdle();
@@ -280,6 +285,7 @@ TEST_F(ServiceWorkerContextTest, RegisterNewScript) {
pattern,
GURL("http://www.example.com/service_worker.js"),
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &old_registration_id, &old_version_id));
ASSERT_FALSE(called);
@@ -295,6 +301,7 @@ TEST_F(ServiceWorkerContextTest, RegisterNewScript) {
pattern,
GURL("http://www.example.com/service_worker_new.js"),
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &new_registration_id, &new_version_id));
ASSERT_FALSE(called);
@@ -322,6 +329,7 @@ TEST_F(ServiceWorkerContextTest, RegisterDuplicateScript) {
pattern,
script_url,
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &old_registration_id, &old_version_id));
ASSERT_FALSE(called);
@@ -337,6 +345,7 @@ TEST_F(ServiceWorkerContextTest, RegisterDuplicateScript) {
pattern,
script_url,
render_process_id_,
+ NULL,
MakeRegisteredCallback(&called, &new_registration_id, &new_version_id));
ASSERT_FALSE(called);

Powered by Google App Engine
This is Rietveld 408576698