src/x64/macro-assembler-x64.cc - Issue 225393005: x64: Make sure that the upper half of a 64bit register contains 0 for int32 values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 225393005: x64: Make sure that the upper half of a 64bit register contains 0 for int32 values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: cvttsd2siq fixes Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 693a5c6b8d4118305ee864e1754106e65fd193af..f8295f68c7bf7e7dc9a5ff07e101a5375be18d91 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -3276,6 +3276,7 @@ void MacroAssembler::TruncateHeapNumberToI(Register result_reg,

}

bind(&done);

+ movl(result_reg, result_reg);

Benedikt Meurer 2014/04/10 16:35:51 Nit: Add a comment why this is necessary.

}

@@ -3292,6 +3293,7 @@ void MacroAssembler::TruncateDoubleToI(Register result_reg,

addp(rsp, Immediate(kDoubleSize));

bind(&done);

+ movl(result_reg, result_reg);

Benedikt Meurer 2014/04/10 16:35:51 Nit: Same.

}

« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/cctest/test-disasm-x64.cc » ('j') | no next file with comments »