Issue 225393005: x64: Make sure that the upper half of a 64bit register contains 0 for int32 values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225393005: x64: Make sure that the upper half of a 64bit register contains 0 for int32 values. (Closed)

Created:
6 years, 8 months ago by Sven Panne

Modified:
6 years, 8 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

x64: Make sure that the upper half of a 64bit register contains 0 for int32 values. BUG=360611 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20664

Patch Set 3 : cvttsd2siq fixes #

Total comments: 2

Patch Set 4 : Rebased. Added comment. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -13 lines)			Patch
M	src/x64/assembler-x64.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	6 chunks	+48 lines, -13 lines	0 comments	Download
M	src/x64/lithium-x64.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/cctest/test-disasm-x64.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

LGTM with nits https://codereview.chromium.org/225393005/diff/40001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://codereview.chromium.org/225393005/diff/40001/src/x64/macro-assembler-x64.cc#newcode3279 src/x64/macro-assembler-x64.cc:3279: movl(result_reg, result_reg); Nit: Add a comment ...

6 years, 8 months ago (2014-04-10 16:35:51 UTC) #2

Sven Panne

6 years, 8 months ago (2014-04-11 06:32:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r20664 (presubmit successful).