Issue 2253683004: Cancel autoplay muted when visible if the video gets unmuted before being visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2253683004: Cancel autoplay muted when visible if the video gets unmuted before being visible. (Closed)

Created:
4 years, 4 months ago by mlamouri (slow - plz ping)

Modified:
4 years, 4 months ago

Reviewers:
Zhiqiang Zhang (Slow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Cancel autoplay muted when visible if the video gets unmuted before being visible. Otherwise, we end up autoplaying unmuted. BUG=627451 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2250393002 Cr-Commit-Position: refs/heads/master@{#412512} (cherry picked from commit c578967369c610605ef62747d0b33f986cab0e23) Committed: https://chromium.googlesource.com/chromium/src/+/f2b3f2f1d6f517ba7fe244c7f7ac385a47b5246e

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -0 lines)			Patch
	A	third_party/WebKit/LayoutTests/media/autoplay-unmute-offscreen.html	View		1 chunk	+66 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/html/HTMLMediaElement.cpp	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

mlamouri (slow - plz ping)

4 years, 4 months ago (2016-08-17 14:01:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f2b3f2f1d6f517ba7fe244c7f7ac385a47b5246e.