Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2250393002: Cancel autoplay muted when visible if the video gets unmuted before being visible. (Closed)

Created:
4 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cancel autoplay muted when visible if the video gets unmuted before being visible. Otherwise, we end up autoplaying unmuted. BUG=627451 R=zqzhang@chromium.org Committed: https://crrev.com/c578967369c610605ef62747d0b33f986cab0e23 Cr-Commit-Position: refs/heads/master@{#412512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/media/autoplay-unmute-offscreen.html View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mlamouri (slow - plz ping)
PTAL :)
4 years, 4 months ago (2016-08-17 11:17:03 UTC) #3
Zhiqiang Zhang (Slow)
lgtm
4 years, 4 months ago (2016-08-17 11:27:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250393002/1
4 years, 4 months ago (2016-08-17 12:21:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 13:34:11 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 13:36:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c578967369c610605ef62747d0b33f986cab0e23
Cr-Commit-Position: refs/heads/master@{#412512}

Powered by Google App Engine
This is Rietveld 408576698