Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6074)

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.h

Issue 2253683002: [DevTools] Introduce a target discovery preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test added Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/devtools_android_bridge.h
diff --git a/chrome/browser/devtools/device/devtools_android_bridge.h b/chrome/browser/devtools/device/devtools_android_bridge.h
index e716b33a4638ff44ef64fbe8876c3967d47a3a90..c935c5af5a088fcb83e8a15537370075361cb06e 100644
--- a/chrome/browser/devtools/device/devtools_android_bridge.h
+++ b/chrome/browser/devtools/device/devtools_android_bridge.h
@@ -37,6 +37,7 @@ class BrowserContext;
class DevToolsTargetImpl;
class PortForwardingController;
class Profile;
+class TCPDeviceProvider;
class DevToolsAndroidBridge : public KeyedService {
public:
@@ -217,6 +218,13 @@ class DevToolsAndroidBridge : public KeyedService {
const std::string& url,
const JsonRequestCallback& callback);
+ typedef base::Callback<void(scoped_refptr<TCPDeviceProvider>)>
dgozman 2016/08/17 00:22:19 typedef -> using
eostroukhov-old 2016/08/17 00:44:22 Did it for all typedefs in this file.
+ tcp_provider_callback;
dgozman 2016/08/17 00:22:19 Types are TitleCase.
eostroukhov-old 2016/08/17 00:44:22 Done.
+ void set_tcp_provider_callback_for_test(tcp_provider_callback callback) {
dgozman 2016/08/17 00:22:19 Move function definition to cc.
eostroukhov-old 2016/08/17 00:44:22 Done.
+ tcp_provider_callback_ = callback;
+ CreateDeviceProviders();
+ }
+
private:
friend struct content::BrowserThread::DeleteOnThread<
content::BrowserThread::UI>;
@@ -293,6 +301,8 @@ class DevToolsAndroidBridge : public KeyedService {
PrefChangeRegistrar pref_change_registrar_;
+ tcp_provider_callback tcp_provider_callback_;
+
base::WeakPtrFactory<DevToolsAndroidBridge> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(DevToolsAndroidBridge);

Powered by Google App Engine
This is Rietveld 408576698