[DevTools] Introduce a target discovery preference

chrome/browser/devtools/device/devtools_android_bridge.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_
 #define CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 19 matching lines @@
 class Thread;
 }  // namespace base
 
 namespace content {
 class BrowserContext;
 }
 
 class DevToolsTargetImpl;
 class PortForwardingController;
 class Profile;
+class TCPDeviceProvider;
 
 class DevToolsAndroidBridge : public KeyedService {
  public:
   class Factory : public BrowserContextKeyedServiceFactory {
    public:
     // Returns singleton instance of DevToolsAndroidBridge.
     static Factory* GetInstance();
 
     // Returns DevToolsAndroidBridge associated with |profile|.
     static DevToolsAndroidBridge* GetForProfile(Profile* profile);
@@ skipping 160 matching lines @@
   void OpenRemotePage(scoped_refptr<RemoteBrowser> browser,
                       const std::string& url);
 
   scoped_refptr<content::DevToolsAgentHost> GetBrowserAgentHost(
       scoped_refptr<RemoteBrowser> browser);
 
   void SendJsonRequest(const std::string& browser_id_str,
                        const std::string& url,
                        const JsonRequestCallback& callback);
 
+  typedef base::Callback<void(scoped_refptr<TCPDeviceProvider>)>

[dgozman, 2016/08/17 00:22:19]

typedef -> using

[eostroukhov-old, 2016/08/17 00:44:22]

Did it for all typedefs in this file.

+      tcp_provider_callback;

[dgozman, 2016/08/17 00:22:19]

Types are TitleCase.

[eostroukhov-old, 2016/08/17 00:44:22]

Done.

+  void set_tcp_provider_callback_for_test(tcp_provider_callback callback) {

[dgozman, 2016/08/17 00:22:19]

Move function definition to cc.

[eostroukhov-old, 2016/08/17 00:44:22]

Done.

+    tcp_provider_callback_ = callback;
+    CreateDeviceProviders();
+  }
+
  private:
   friend struct content::BrowserThread::DeleteOnThread<
       content::BrowserThread::UI>;
   friend class base::DeleteHelper<DevToolsAndroidBridge>;
 
   friend class PortForwardingController;
 
   class AgentHostDelegate;
   class DiscoveryRequest;
   class RemotePageTarget;
@@ skipping 56 matching lines @@
   DeviceCountListeners device_count_listeners_;
   base::CancelableCallback<void(int)> device_count_callback_;
   base::Callback<void(const base::Closure&)> task_scheduler_;
 
   typedef std::vector<PortForwardingListener*> PortForwardingListeners;
   PortForwardingListeners port_forwarding_listeners_;
   std::unique_ptr<PortForwardingController> port_forwarding_controller_;
 
   PrefChangeRegistrar pref_change_registrar_;
 
+  tcp_provider_callback tcp_provider_callback_;
+
   base::WeakPtrFactory<DevToolsAndroidBridge> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DevToolsAndroidBridge);
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_