[DevTools] Copy objects from debugger context to inspected context properly.

[DevTools] Copy objects from debugger context to inspected context properly.

BUG=637594
Committed: https://crrev.com/93bc623489bdcfc7e9127614fcfb3258edf3f0f9
Cr-Commit-Position: refs/heads/master@{#412436}

[dgozman, 2016-08-16 16:54:06]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 16:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-08-16 16:56:27]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, pfeldman@chromium.org

[dgozman, 2016-08-16 16:56:28]

Take a look please.

[commit-bot: I haz the power, 2016-08-16 16:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 16:56:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pfeldman, 2016-08-16 17:07:36]

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp (right):

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:662: bool success
= console->SetPrototype(context, v8::Object::New(isolate)).FromMaybe(false);
You want 'null', not an object, otherwise I don't think that you are fixing
anything.

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:709: bool success
= commandLineAPI->SetPrototype(context, v8::Null(isolate)).FromMaybe(false);
Since these are configurable, user will re-define dir/dirxml/etc anyways, so
this has no effect.

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp (right):

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp:626:
v8::Local<v8::Array> result = v8::Array::New(m_isolate, scopes->Length());
This is too fragile and adhock. You leak one array and compromise the entire
context.

[dgozman, 2016-08-17 00:47:26]

Description was changed from

==========
[DevTools] Do not expose objects from debugger context to InjectedScript.

This also clears prototype of any objects created by debugger.

BUG=637594
==========

to

==========
[DevTools] Adapt objects from debugger context to inspected context properly.

BUG=637594
==========

[dgozman, 2016-08-17 00:58:32]

PTAL at new verison

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp (right):

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:662: bool success
= console->SetPrototype(context, v8::Object::New(isolate)).FromMaybe(false);
On 2016/08/16 17:07:36, pfeldman wrote:
> You want 'null', not an object, otherwise I don't think that you are fixing
> anything.

This is a part of console prototype "spec".

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:709: bool success
= commandLineAPI->SetPrototype(context, v8::Null(isolate)).FromMaybe(false);
On 2016/08/16 17:07:36, pfeldman wrote:
> Since these are configurable, user will re-define dir/dirxml/etc anyways, so
> this has no effect.

Right, but this helps a bit.

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp (right):

https://codereview.chromium.org/2253643002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp:626:
v8::Local<v8::Array> result = v8::Array::New(m_isolate, scopes->Length());
On 2016/08/16 17:07:36, pfeldman wrote:
> This is too fragile and adhock. You leak one array and compromise the entire
> context.

Updated.

[pfeldman, 2016-08-17 01:33:28]

lgtm

https://codereview.chromium.org/2253643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/DebuggerContextAdapter.cpp
(right):

https://codereview.chromium.org/2253643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/DebuggerContextAdapter.cpp:80:
v8::MaybeLocal<v8::Value> adaptValueFromDebuggerContext(v8::Isolate* isolate,
v8::Local<v8::Context> debuggerContext, v8::Local<v8::Context> toContext,
v8::Local<v8::Value> value)
adoptValue

https://codereview.chromium.org/2253643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp (right):

https://codereview.chromium.org/2253643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp:596: if
(!adaptValueFromDebuggerContext(m_isolate, debuggerContext(), context,
scopesValue).ToLocal(&adapted) || !adapted->IsArray())
adopt

[dgozman, 2016-08-17 01:46:12]

Description was changed from

==========
[DevTools] Adapt objects from debugger context to inspected context properly.

BUG=637594
==========

to

==========
[DevTools] Copy objects from debugger context to inspected context properly.

BUG=637594
==========

[dgozman, 2016-08-17 01:49:09]

https://codereview.chromium.org/2253643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/DebuggerContextAdapter.cpp
(right):

https://codereview.chromium.org/2253643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/DebuggerContextAdapter.cpp:80:
v8::MaybeLocal<v8::Value> adaptValueFromDebuggerContext(v8::Isolate* isolate,
v8::Local<v8::Context> debuggerContext, v8::Local<v8::Context> toContext,
v8::Local<v8::Value> value)
On 2016/08/17 01:33:28, pfeldman wrote:
> adoptValue

Went with copyValue.

[dgozman, 2016-08-17 01:49:21]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-08-17 01:49:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2253643002/#ps60001
(title: "copier")

[commit-bot: I haz the power, 2016-08-17 01:49:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 03:03:13]

Description was changed from

==========
[DevTools] Copy objects from debugger context to inspected context properly.

BUG=637594
==========

to

==========
[DevTools] Copy objects from debugger context to inspected context properly.

BUG=637594
==========

[commit-bot: I haz the power, 2016-08-17 03:03:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-17 03:06:13]

Description was changed from

==========
[DevTools] Copy objects from debugger context to inspected context properly.

BUG=637594
==========

to

==========
[DevTools] Copy objects from debugger context to inspected context properly.

BUG=637594

Committed: https://crrev.com/93bc623489bdcfc7e9127614fcfb3258edf3f0f9
Cr-Commit-Position: refs/heads/master@{#412436}
==========

[commit-bot: I haz the power, 2016-08-17 03:06:14]

Patchset 4 (id:??) landed as
https://crrev.com/93bc623489bdcfc7e9127614fcfb3258edf3f0f9
Cr-Commit-Position: refs/heads/master@{#412436}

[kozy, 2016-08-23 01:46:34]

lgtm